Fixed Empty template name for template_modification?

[Snog]

This is strange.

I have a template modification that showing that it's been successfully applied to two templates, but only one has a name:



Any ideas what would cause this? It should in reality only be applied to one template.

 

[Snog]

This may be a bug somewhere.

I disabled the template modification and it's still showing as being applied to the un-named template.





A little background that might help. I switched my development server so it has a copy of my live site, upgraded to XF 2 Beta 7.

I didn't see this on a straight install of Beta 7, only after the upgrade.

All other add-ons/modifications are disabled, so it's not another add-on interfering.

 

[Snog]

There is definitely a bug somewhere.

I decided to delete the modifications that were doing this and to re-enter them. As I entered them, they all returned to being the proper apply count.

But, I made a mistake on one of them and edited it. After editing, one of the other modifications for the same 'thread_list_macros' template, for the same add-on, changed to show 2 modifications like my original post. I had to delete it a second time and re-enter it to get the correct apply count.

 

[Snog]

I just checked the database and the template modifications are showing as being applied to non-existent templates.

This appears to happen when you have more than one modification defined for the same template (modifying 2 different sections of the template).

 

[Mike]

The only way I can see this happening is from XF1 data being in the xf_template_modification_log table. There is a bug in that we don't clean up this table with the 2.0 upgrade, so I'll fix that.

Though are you implying in your last messages that you have a more consistent reproduction case. If so, I can't reproduce that, so we'll need exact steps.

 

[Snog]

@Mike I haven't been able to recreate again while just editing the modifications.

I think you would be fine marking this as fixed.

 

[ge66]

The only way I can see this happening is from XF1 data being in the xf_template_modification_log table. There is a bug in that we don't clean up this table with the 2.0 upgrade, so I'll fix that.

Though are you implying in your last messages that you have a more consistent reproduction case. If so, I can't reproduce that, so we'll need exact steps.

Just wanted to let you know that something similar happened to me today, still on RC1 and updated from 1.5, so it could aldready be solved.

 

[AndyB]

The fix is to uninstall the add-on and reinstall it again.