Fixed embed.php missing

[MattW]

Affected version

2.3

I've upgraded multiple sites now to XF2.3, and all of them are missing the new embed.php file that is mentioned in the HYS about embedding content.

public]# ll | grep php
-rw-r--r--  1 nginx nginx   319 Aug 12 10:03 admin.php
-rw-r--r--  1 nginx nginx   336 Aug 12 10:03 cmd.php
-rw-r--r--  1 nginx nginx  1993 Aug 12 10:03 connected_account.php
-rw-r--r--  1 nginx nginx   831 Aug 12 10:03 css.php
-rw-r--r--  1 nginx nginx   433 Aug 12 10:03 index.php
-rw-r--r--  1 nginx nginx  1359 Aug 12 10:03 job.php
-rw-r--r--  1 nginx nginx   895 Aug 12 10:03 oembed.php
-rw-r--r--  1 nginx nginx  1759 Aug 12 10:03 payment_callback.php
-rw-r--r--  1 nginx nginx   189 May  3  2018 photocompetition.php
-rw-r--r--  1 nginx nginx  1000 Aug 12 10:03 proxy.php
-rw-r--r--  1 nginx nginx  3092 Aug  3  2014 resources.php
-rw-r--r--  1 nginx nginx   718 Aug  6  2014 robots.php
-rw-r--r--  1 nginx nginx   405 Aug 12 10:03 sitemap.php
-rw-------  1 nginx nginx  6384 Feb 16  2014 spamcheck.php
-rw-r--r--  1 nginx nginx  1865 Aug 12 10:03 unfurl.php
-rw-r--r--  1 nginx nginx   502 Aug 12 10:03 webmanifest.php

I've downloaded the full XF2.3 package just now, and it's included in there, so wondering if it's missing from the upgrade package (all the upgrades have been the one click upgrades).

 

[Paul B]

I just checked the upgrade package for my license and it's there.

 

[Chris D]

Is it listed in src/addons/XF/hashes.json @Paul B?

 

[MattW]

I've checked every site I've upgraded, including my own, and it's missing from them all. I've downloaded the package, and manually uploaded that file to get the function to work. A customer of mine reported it as I've not used the feature, as theirs was missing as well.

 

[Paul B]

It is not.

 

[MattW]

Is it listed in src/addons/XF/hashes.json @Paul B?

[14:34][root@host.mattw.services public]# cat src/addons/XF/hashes.json | grep embed.php
    "oembed.php": "1b016770eeea5c1edbae88273f5d4adc19475ca5e7ce2f6812f813d38b38001f",
    "src/XF/Entity/Oembed.php": "e9473e72fa1fa65ce7a7d456ec82e6bf629ed2742a13474e3ab0687022931192",
    "src/XF/SubContainer/Oembed.php": "1476dc89000a04f07bf51bac0a43c01877c58875eec293964d161e6f3165c441",
[14:34][root@host.mattw.services public]#

 

[Chris D]

It is not.

That's the issue then. It's being deleted because its not in the hashes.json file, so it is assumed it is no longer a relevant file.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.4).

Change log:

Include embed.php in hashes.json

There may be a delay before changes are rolled out to the XenForo Community.