Fixed Embed metadata jobs output status messages that are identical to other jobs

[Chris D]

Affected version

2.3.13

In src/XF/Job/AbstractRebuildJob.php the getStatusMessage method reads like this:

public function getStatusMessage()
{
    $actionPhrase = \XF::phrase('rebuilding');
    $typePhrase = $this->getStatusType();
    return sprintf('%s... %s (%s)', $actionPhrase, $typePhrase, $this->data['start']);
}

For the conversations/direct messages rebuild, for example, this will output Rebuilding... Direct messages.

In src/XF/Job/ConversationEmbedMetadata.php the getActionDescription method reads like this:

    protected function getActionDescription(): string
    {
        $rebuildPhrase = \XF::phrase('rebuilding');
        $type = \XF::phrase('direct_messages');
        return sprintf('%s... %s', $rebuildPhrase, $type);
    }

As a result, the ConversationEmbedMetadata job will also output Rebuilding... Direct messages.

This can be confusing when monitoring an Atomic job (for example, triggered after an import) that includes both jobs as the distinct steps have duplicated status messages to earlier steps, each with their own progress output.

This affects multiple content types.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.14).

Change log:

Show distinct progress messages for embed metadata rebuilds (#2713)

There may be a delay before changes are rolled out to the XenForo Community.