Awaiting feedback DirectoryIterator significant performance degradation compared to native functions

[Painbaker]

Affected version

2.3.4

Having hundreds of installed add-ons on causes progressive performance degradation not related to add-ons code.

I did some debugging and bottleneck profiling and found that the root cause of the problem was DirectoryIterator which is used when traversing addon files in performance-critical places like XF\AddOn\Manager, XF\DevelopmentOutput\DevelopmentOutput and XF\Cli\Runner

Even though an NVMe 1.4 drive is used with high iops, SPL functions has slower execution compared to native readdir/opendir functions:

 

[Chris D]

I assume this is a somewhat rare side effect of having over 600 add-ons on one XF install for development purposes?

In that context, I agree a 600% speed increase might be useful, but I would expect this change would likely be saving milliseconds for most customers, rather than seconds.

 

[Sim]

Is the DirectoryIterator called at any point during an end-user operation such as browsing the forum? Or is it only during admin/developer operations such as managing addons or running CLI tasks?

 

[Chris D]

Pretty much that I believe. At least where it matters.

 

[Painbaker]

I assume this is a somewhat rare side effect of having over 600 add-ons on one XF install for development purposes?

Sure, this will not have a significant impact on most production forums and may only give a few percent boost.