Fixed Demotions for a User Group Promotion only sometimes apply

[Xon]

When a user logs in, the user promotion code will get evaluated. Regardless of if they are banned or the account state isn't valid. This will result in the full criteria being evaluated and any demotions/promotions applying as expected.

But the cron task, and deferred task only apply to non-banned valid users. Despite this being part of the selection criteria for when a promotion applies and is then expected to unapply.

 

[Mike]

I've changed this to run on banned/non-valid users as well. The same change has been made to trophies to be consistent, though I don't think it's really significant there.