Fixed Custom BBCode and quick save

[Arty]

Affected version

2.1.0

I've attached a custom add-on that implements "test" bbcode. Its as basic as possible to demonstrate bug.

It uses template engine to render custom BBCode.

It highlights contents in red color:

[test]qwerty[/test]

is turned into this HTML:

<span style="color: red">qwerty</span>

BBCode is simple: its a PHP callback that renders template public:bbcode_test.
Contents of callback:

public static function getHTML($tagChildren, $tagOption, $tag, array $options, \XF\BbCode\Renderer\AbstractRenderer $renderer)
{
    $content = $renderer->renderSubTree($tagChildren, $options);

    /* @var \XF\Template\Templater $templater */
    $templater = $renderer->getTemplater();
    $content = $templater->renderTemplate('public:bbcode_test', [
        'content' => $content
    ], true);

    return $content;
}

Contents of public:bbcode_test:

<span style="color: red">{{ $content | raw }}</span>

So it is very simple. Here is bug: if post is saved from quick edit, BBCode is rendered using master style instead of currently selected style.

How to test it:

• Install this test add-on
• In default style edit template "bbcode_test". Change it to this:

  <span style="color: green">{{ $content | raw }}</span>

  so in master style highlight is red, in default style highlight is green
• Go to visitor area, make sure default style is selected, create sample post:

  [test]qwerty[/test]

• Click "Post thread" to submit thread.
• Post will have "qwerty" in green color, as it is supposed to (because in default style it was changed to green).
• Click "Edit" link below post to show quick edit.
• Do not change anything, simply click "Save".
• Post will refresh and "qwerty" will be in red color instead of green.

 

[Mike]

I can't reproduce this, though it's possible that there's another bug fix in 2.1.1 that is relevant (related to template caching).

As a test, you may be able to switch the master version to:

<xf:set var="$templater" value="{{ templater() }}" />
<span style="color: red">{{ $content | raw }} [{{ $templater.getStyleId() }}]</span>

And then change the default style version to green as before.

If it reports a style ID other than 0 but it renders the master version, then that could be the bug I'm thinking of. At this point, it may be easiest to just have you reconfirm once 2.1.1 is released.

 

[Arty]

Yes, it shows [1], but renders master version.

 

[Chris D]

In that case, I think we're confident enough that this is fixed in XF 2.1.1

Not going to directly call it a duplicate, but the changes were made while we were fixing this one:

Fixed - Push notifications are not sent in the language selected by the user

As the title says, notifications are sent in the language of the user who triggered the notification Steps to Reproduce: With another account select another language and react to one of your messages. Change language again and react to another of your messages. Expected behavior: You receive...

xenforo.com