Fixed Ctrl-click on post Edit/Reply eats open-in-new-tab behaviour

[Xon]

Affected version

2.0.2

In Chrome on Windows, typically holding the ctrl key and clicking a link will open it in a new tab/window. XF appears to suppress this when clicking on the edit link.

Especially as there is no longer a 'more options' link, you need to middle-click to get the open-in-new-tab behaviour.

 

[Chris D]

I'm hesitantly making a fairly large change to fix this, in that by default data-xf-click handlers will bail out if it is a link and are clicked with a modifier key or a key other than left click. We actually had that behaviour for overlays already, but I've moved it up to the actual click handler watcher. It's possible to opt out of that by adding data-click-allow-modifier="true".

I've rolled that out here and it shouldn't break anything... famous last words... but we'll see.