1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed CSS vendor prefix issue for ending declarations with no semicolon

Discussion in 'Resolved Bug Reports' started by Despair, Apr 1, 2013.

  1. Despair

    Despair Active Member

    CSS that automatically add any vendor prefixes must require a terminating semi colon, otherwise it messes up your css. This would only happen if you use any of the css that generate vendor prefixes such as border-radius, box-shadow, etc. as the last declaration in a block which doesn't necessarily require an ending semi colon (although probably better practise to do so).

    If the semicolon is seen as a terminator instead of a separator, maybe nothing additional should be added if no semicolon is found? Currently what it seems to do if there is no trailing semi colon is it takes the next css block and adds the vendor prefix to it. This repeats itself for how many vendor prefixes there are of that type. So in the end you could have multiple extra blocks of css code with the wrong declarations attached to it (in the worst case scenario it copied the entire next stylesheet a few times adding the prefix to it). The resulting behaviour will probably be different than I described as well since this was applied http://xenforo.com/community/threads/incorrect-css3-prefixes-position.47117/. It's possible that even fixes it unknowingly.

    I think I remembering running into this issue a long time ago, but never reported it, probably thought it wasn't worth fixing, but after running into it again, mind as well report it. :p
  2. Mike

    Mike XenForo Developer Staff Member

    Should be fixed now. Hopefully there won't be any issues with the regex adjustments. Obviously adding a semi-colon is the simple workaround for this.

Share This Page