1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Copying posts from a thread triggers rebuild of counters in source thread

Discussion in 'Resolved Bug Reports' started by Xon, Aug 27, 2015.

  1. Xon

    Xon Well-Known Member

    XenForo_Model_Post::_moveOrCopyPosts calls rebuildDiscussion() on all source threads, regardless of if it is a move or copy operation.

    This causes copying posts from a massively long thread to take an unexpectedly long time.
     
  2. Solidus

    Solidus Well-Known Member

    Define massively long, I have a thread with 3500 replies and would like to test that.
     
  3. Xon

    Xon Well-Known Member

    It was a thread with ~58000 replies. I'm aware that is longer than most normal threads!
     
  4. RoldanLT

    RoldanLT Well-Known Member

    My top replied thread is only:
    14, 355
    10, 619
    7, 796

    So I will try this one too.
     
  5. RoldanLT

    RoldanLT Well-Known Member

    Tried, and it was quick for me.
     
  6. Daniel Hood

    Daniel Hood Well-Known Member

    Regardless of speed, it's still an unnecessary task. There's no need to rebuild thread data for threads that weren't modified (moving makes sense, copying does not).
     
    Xon and Rob like this.
  7. Mike

    Mike XenForo Developer Staff Member

    I've adjusted this, thanks.
     
    Daniel Hood and Xon like this.

Share This Page