Fixed Copying posts from a thread triggers rebuild of counters in source thread

[Xon]

XenForo_Model_Post::_moveOrCopyPosts calls rebuildDiscussion() on all source threads, regardless of if it is a move or copy operation.

This causes copying posts from a massively long thread to take an unexpectedly long time.

 

[m1ne]

Define massively long, I have a thread with 3500 replies and would like to test that.

 

[Xon]

Define massively long, I have a thread with 3500 replies and would like to test that.

It was a thread with ~58000 replies. I'm aware that is longer than most normal threads!

 

[rdn]

My top replied thread is only:
14, 355
10, 619
7, 796

So I will try this one too.

 

[rdn]

14, 355

Tried, and it was quick for me.

 

[Daniel Hood]

Regardless of speed, it's still an unnecessary task. There's no need to rebuild thread data for threads that weren't modified (moving makes sense, copying does not).

 

[Mike]

I've adjusted this, thanks.