Fixed Conversation recipients: Pressing escape should cancel instead of confirm

[Steffen]

Affected version

2.0.6 Beta 1

How to reproduce: Go to https://xenforo.com/community/conversations/add and start typing a recipient name, wait until the autocomplete popup appears with the first entry preselected, then press the escape key.

Expected behaviour: The autocomplete popup should just disappear and not implicitly choose the preselected entry.

What actually happens: The autocomplete popup disappears and implicitly chooses the preselected entry (same as pressing the enter key).

Browser is Chrome 66 on Linux.

 

[Chris D]

Select2 has two behaviours based on an option called selectOnClose, we had it set to true, so escape or blurring the input would select the highlighted result. I've now set it to false. To be clear though, although this no longer selects the highlighted result on pressing Escape, it does also clear the text you typed since the last recipient was added. Not sure if that's desirable or a step backwards but we're stuck with one behaviour or the other.