1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Conversation.php

Discussion in 'Resolved Bug Reports' started by Syndol, Mar 7, 2012.

  1. Syndol

    Syndol Guest

    As this is not technically a bug, I am therefore suggesting ;) the following:
    In Model/Conversation.php, it would be nice if $fetchOptions was actually used in the
    getConversationRecipient(s) function.
     
    erich37, Hardcore and guiltar like this.
  2. Syndol

    Syndol Guest

    On the same subject, could we please also have $orderClause in function getConversationsForUser() where it is badly needed as you have everything else but that.
     
  3. Syndol

    Syndol Guest

    Any chance of including this in the next update.
    Thank you.
     
  4. Mike

    Mike XenForo Developer Staff Member

    Have added $fetchOptions for 1.1.4, ordering isn't something that conversations have a framework for (like some of the other models) so it's not something I'd do for a maintenance release.
     
    Slavik likes this.
  5. Syndol

    Syndol Guest

    Thanks for fixing the $fetchOptions, but in regards to the order clause, I thought XenForo prides itself on being easy to extend.
    By not including a simple order key in the fetch array you are forcing people who need it to overwrite the whole function.
     

Share This Page