• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Conversation.php

S

Syndol

Guest
#1
As this is not technically a bug, I am therefore suggesting ;) the following:
In Model/Conversation.php, it would be nice if $fetchOptions was actually used in the
getConversationRecipient(s) function.
 
S

Syndol

Guest
#2
On the same subject, could we please also have $orderClause in function getConversationsForUser() where it is badly needed as you have everything else but that.
 

Mike

XenForo developer
Staff member
#4
Have added $fetchOptions for 1.1.4, ordering isn't something that conversations have a framework for (like some of the other models) so it's not something I'd do for a maintenance release.
 
S

Syndol

Guest
#5
Thanks for fixing the $fetchOptions, but in regards to the order clause, I thought XenForo prides itself on being easy to extend.
By not including a simple order key in the fetch array you are forcing people who need it to overwrite the whole function.