• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Conversation.php instantiates XenForo_Mail directly

Rigel Kentaurus

Well-known member
#1
In conversation.php, near line 704 (of 1.1beta 2), the class XenForo_Mail is instantiated directly, instead of using XenForo_Mail::create()

The problem with this is that the class then bypasses all the hooks, and any listener on the load_class_mail would never get executed.

Same thing is also found in ThreadWatch#218

Screnshot for snippet of Conversation.php
Screen Shot 2011-10-17 at 9.30.23 AM.png
 
R

ragtek

Guest
#2
btw
XenForo_Model_ThreadWatch too

line 218
PHP:
$mail = new XenForo_Mail($emailTemplate, array(