1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Conversation.php instantiates XenForo_Mail directly

Discussion in 'Resolved Bug Reports' started by Rigel Kentaurus, Oct 17, 2011.

  1. Rigel Kentaurus

    Rigel Kentaurus Well-Known Member

    In conversation.php, near line 704 (of 1.1beta 2), the class XenForo_Mail is instantiated directly, instead of using XenForo_Mail::create()

    The problem with this is that the class then bypasses all the hooks, and any listener on the load_class_mail would never get executed.

    Same thing is also found in ThreadWatch#218

    Screnshot for snippet of Conversation.php
    Screen Shot 2011-10-17 at 9.30.23 AM.png
    Mike Tougeron and ragtek like this.
  2. ragtek

    ragtek Guest

    XenForo_Model_ThreadWatch too

    line 218
    $mail = new XenForo_Mail($emailTemplate, array(
  3. Rigel Kentaurus

    Rigel Kentaurus Well-Known Member

    And in Ragtek_Helper_Mail::sendMail ;)
  4. ragtek

    ragtek Guest

    hm, that's from an very old add-on:D

    ragtek_helper is deprecated, my ragtek addon helper framework exists now instead of the helper
  5. Kier

    Kier XenForo Developer Staff Member

    Mike Tougeron likes this.

Share This Page