Fixed [code] tags do not accept whitespace

[Erik]

What I mean is that code tags trim whitespace like regular content. In other words indenting, etc. is not preserved.

For example:

if($codetags->preserveWhitespace()) {
//this should be indented
$erik->makeHappy();
} else {
// also indented
fix();
}

PHP tags are the same:

<?php
if($codetags->preserveWhitespace()) {
//this should be indented
$erik->makeHappy();
} else {
// also indented
fix();
}
?>

On a related note, if you hit the tab key within the editor (either the quick reply or the full editing page), it tabs out to the next form field instead of creating a tab character. (edit: nevermind, as designed )

These two combined make posting and formatting code a nightmare at the moment. Long pieces of code are almost impossible to read without proper whitespace and indenting.

 

[Enigma]

On a related note, if you hit the tab key within the editor (either the quick reply or the full editing page), it tabs out to the next form field instead of creating a tab character.

I see that as normal, expected behavior.

 

[Erik]

I see that as normal, expected behavior.

You're right, that's how vBulletin's editor currently works as well. I guess as I was trying to create indentation in the code examples I was thinking to myself, "the tab key should really create a tab character." But I can see how this is operating as designed.

 

[Disjunto]

No indent
 Single tab index
 Double tab indent
Single space indent
  Tab+Space indent
  2Tab+Space indent
   2Tab+2Space indent
   2Tab+10Space indent

Very strange behaviour

 

[Kuma]

Might just need some <pre> tags.

 

[Disjunto]

Might just need some <pre> tags.

it's already in a pre, they just need to change how the pre treats whitespace

 

[Kuma]

I think the white space was stripped somewhere. Looking at the html, there does not apear to be any whitespace in the text.

test

I sent ten spaces and typed test, the html source has all lf the spaces removed: http://pastebin.com/J3gpdAQ2

 

[Disjunto]

yeah, I remembered I had already checked that after posting... and for some reason never edited my post. oh well

 

[Mike]

This should be fixed for new posts now. I also discovered an issue with editing code as well.

a
    spaces
 tab

 

[Mike]

Hmm, the tab went weird on me. Worked in tests...

 

[Mike]

Looks Chrome specific, and IE has some different behaviors. I don't know if I can workaround these issues very easily, but I'll see what I can come up with.

 

[Erik]

Just FYI, I'm running Firefox 3.6 and in the example above I see four spaces before the word "spaces", and then one space before the word "tab."

Thanks for taking a look.

 

[Mike]

Fixed, though I'm not 100% happy with the fix.

IE also does annoying stuff when pasting in tabs. (It also paste from Eclipse with syntax highlighting.) This, unfortunately, causes all sorts of nightmares with BB codes showing up within. I'll have to deal with that.

Do definitely need a way to go from the WYSIWYG editor to a BB code based version, though all the buttons would go away.

 

[Erik]

Do definitely need a way to go from the WYSIWYG editor to a BB code based version, though all the buttons would go away.

Yeah, this would be much appreciated. Earlier today the editor was still doing some funky stuff with tabs and whitespace as I was editing and stuff. That might be fixed now, I'll let you know if it's not.

Also, if you could fix that extra line break in the quote box that would be great too.

 

[Enigma]

Do definitely need a way to go from the WYSIWYG editor to a BB code based version, though all the buttons would go away.

Definitely agree with you on this, except for the part about the buttons going away