Confirmed Client side image resizing fails if image is inserted via toolbar icon

[Kirby]

Affected version

2.3.0 Beta 2

Prerequisites

1. Set post_max_size and upload_max_filesize to 1 MB
2. Set max image dimensions to 300 x 300

Steps to reproduce

1. Click the editor toolbar icon Insert image
2. Drop a large image (well > 1 MB and over 300x300) onto the drop area

Expected Result
The image is resized to max. 300 x 300 and uploaded afterwards

Actual Result
The source image is uploaded, the upload fails without a user-facing error

Suggested Fix
The upload must be routed through the attachment manager so client side image resizing is used

XF 2.3 Post in thread 'Image optimization, enhanced image resizing, and more!'

Nov 10, 2023

To support our chunked uploads Add-on I ended up just bypassing Froala uploads (via Insert Video dialog) and routing everything through flow.js, a similar approach could work for Images as well.

Yeah we're looking at just routing everything through the attachment manager.

Hmm, yeah - that doesn't really answer my question

It does, but to be clearer we attempt WebP conversion client-side prior to upload. So, a 1920x1920 WebP.

• Jeremy P

• 

 

[Jeremy P]

Yeah, this is in our backlog.

 

[CZ Eddie]

So, to confirm we still need to use the "attach files" instead of the "insert image" from the toolbar?
Just making sure while I'm troubleshooting this.

I literally just this week told my users to stop using the Attach Files

 

[Kirby]

Yeah, this is in our backlog.

Is it still on the backlog 4 months later after the release of 2.3 final?

Client side resizing / conversion is severely less efficient if this issue isn't fixed as many users don't upload images via Attach files button but via Drag & Drop onto the editor or by using the Insert image toolbar icon

 

[bzcomputers]

Is it still on the backlog 4 months later after the release of 2.3 final?

Will there ever really be a final version of XenForo with over 500 open bug reports still?

I don't think I'll ever understand how XenForo got to this point or how they will ever recover from such a back log. I know some bugs are trivial and this one is by far not, but having a newly released 2.3 after years of waiting and there still being 580 open bug reports just does not make sense.