Fixed Can't tag a user with \\ in front of their name

[Steve F]

Not sure if it happens on other things as well but we have a user with \\ in front of their name and we can't tag them, name does not come up in the preview either. We changed the users name to just have 1 '\' but we still can't tag them.

 

[Amaury]

Do you know of any members here with slashes? I can test it and see if I can confirm it.

 

[Steve F]

Same result for me trying to tag

http://xenforo.com/community/members/zz-xa.51885/

 

[Amaury]

Testing. @\\\zz\xa

Confirmed.

 

[imthebest]

@\\\zz\xa

Confirmed, too.

 

[TheBigK]

One of our users's Id is [Prototype] and he doesn't appear in the @ suggestions.

 

[Mike]

Fixed now. Looks like a bug with the actual look up -- this is a place where we needed to double escape backslashes.

Regarding @[name here] type matches, they create an ambiguity with BB codes so they can't be tagged. That's generally as designed (it mostly just applies if their name starts with a "[").

 

[Steve F]

Fixed now. Looks like a bug with the actual look up -- this is a place where we needed to double escape backslashes.

Regarding @[name here] type matches, they create an ambiguity with BB codes so they can't be tagged. That's generally as designed (it mostly just applies if their name starts with a "[").

Could you share the fix @Mike? If it is easy enough to do.

Thanks!

 

[Mike]

In library/XenForo/Db.php, change:

$string = str_replace(array('%', '_'), array('\\%', '\\_'), $string);

to:

$string = str_replace(array('\\', '%', '_'), array('\\\\', '\\%', '\\_'), $string);