Fixed Bug when manually inserting page number in URL of profile

[imthebest]

This: https://xenforo.com/community/members/mike.3/?page=20

 

[Amaury]

That's because Mike only has 14 pages of profile posts.

 

[imthebest]

I know and that's the bug.

The proper way in how this should work is this: https://xenforo.com/community/media/me.49/?page=20

 

[Daniel Hood]

I think either way of handling it is fine. If users are intentionally trying to access pages they shouldn't, I don't see the benefit of redirecting them somewhere we -think- they want to be.

 

[imthebest]

Well if it isn't a bug then at least there is inconsistency between XF and XFMG.

But I think that XFMG way of dealing with this is better. But in case you want to stick with the XF way then instead of "There are no messages on Mike's profile yet" (which isn't true) you should display something like "The page number you have requested doesn't exists".

 

[Daniel Hood]

Well if it isn't a bug then at least there is inconsistency between XF and XFMG.

But I think that XFMG way of dealing with this is better. But in case you want to stick with the XF way then instead of "There are no messages on Mike's profile yet" (which isn't true) you should display something like "The page number you have requested doesn't exists".

Or... you can ban the members trying to do malicious things on your site because there's very few people that manually change a part of the url like that without bad intent.

I don't mind if they change the behavior. I guess it's cool Chris did in the gallery. But this is really a non issue because it doesn't really affect anything. It'd be an issue if there the pager buttons linked there but nothing links there. You have to manually tamper with the url in order to even see that message.

 

[imthebest]

Well not only on XFMG but also on XF threads: https://xenforo.com/community/threads/searchaction-markup-for-google.83223/page-20

Actually the RM behaves a bit different and just redirects you to the Overview (when viewing reviews): https://xenforo.com/community/resources/s9e-media-bbcodes-pack.2476/reviews?page=20

And a blank page (when viewing updates): https://xenforo.com/community/resources/s9e-media-bbcodes-pack.2476/updates?page=20

Not something critical I agree but at least it's clear we need some consistency here.

 

[Daniel Hood]

but at least it's clear we need some consistency here.

We'll agree to disagree. To me this couldn't be less of an issue. These are urls that nobody should ever visit. Anyone doing that is just looking for bugs to exploit (not literally -anyone- but definitely the strong majority, the rest are trying to shortcut to a page they recall and that's super rare).

 

[Mike]

Fixed, thanks.

 

[Valhalla]

But I think that XFMG way of dealing with this is better. But in case you want to stick with the XF way then instead of "There are no messages on Mike's profile yet" (which isn't true) you should display something like "The page number you have requested doesn't exists".

In many cases you get taken to the last page available.