XF 1.5 Bug/Issue: Can't quote proxy images.

[andrewkm]

My message / images options are as follows:

If I quote "reply" to an entire post with an image and reply to it, it works fine:

The reply does include the image:

*HOWEVER*

If I select the "IMAGE" only:

And click "reply"

The actual reply does not include the image:

This I'm almost certain is a Xenforo "bug".

Please advise.
Thanks!

 

[Martok]

Testing...

It works here.

Does the issue persist with add-ons disabled and using an unedited default style?

 

[andrewkm]

Testing...

It works here.

Does the issue persist with add-ons disabled and using an unedited default style?

Sorry for the late reply, was on vacation.
Yes still happens.

http://i.imgur.com/JU48Ijf.png
http://i.imgur.com/TgydH8M.png

@Mike anything I can do here?

 

[andrewkm]

Testing bug here.

Edit: Can't seem to reproduce here on the Xenforo forums.
BTW i'm using xenforo image proxy.

 

[Mike]

Can you provide a demo URL that shows both of the posts in your screenshot?

 

[andrewkm]

Can you provide a demo URL that shows both of the posts in your screenshot?

https://www.ecocitycraft.com/forum/threads/testing.150899/

 

[Mike]

I have made a fix here for the next release, but I think your issue might be related to your server's ability to fetch an image from itself via the image proxy. For example, put this URL into the "test image proxy" tool:

http://i.imgur.com/zZ7XiGN.png

Does it fetch correctly? It should. If not, that's what is ultimately breaking the image.

My change prevents the "double nesting" of the image proxy that could previously happen.

 

[andrewkm]

I have made a fix here for the next release, but I think your issue might be related to your server's ability to fetch an image from itself via the image proxy. For example, put this URL into the "test image proxy" tool:

http://i.imgur.com/zZ7XiGN.png

Does it fetch correctly? It should. If not, that's what is ultimately breaking the image.

My change prevents the "double nesting" of the image proxy that could previously happen.

Looks good here,

Also it looks like I cannot reproduce on this page however:

http://primomc.net/threads/image-proxy-reply.48/

A forum ran by a friend @kukelekuuk00

Do you see any differences with why it would work for him and not us.

He has both image proxy/link proxy enabled just as I do.

 

[Mike]

Oops, my link got converted incorrectly in the post.

You want to test:

https://www.ecocitycraft.com/forum/proxy.php?image=http%3A%2F%2Fi.imgur.com%2FzZ7XiGN.png&hash=ea1bb207711f5363852dd26d764ff3e3

 

[andrewkm]

Oops, my link got converted incorrectly in the post.

You want to test:

https://www.ecocitycraft.com/forum/proxy.php?image=http%3A%2F%2Fi.imgur.com%2FzZ7XiGN.png&hash=ea1bb207711f5363852dd26d764ff3e3

I am getting the following:

Anything I can do to fix this?

 

[andrewkm]

@Mike

Fixed by removing 127.0.0.1 -> www.ecocitycraft.com from our host file

The reason for this was because we don't run HTTPS locally and instead use Cloudflare for SSL masking.