Bookmark 1.9

[audiokid]

nice one Andy!

 

[AndyB]

AndyB updated Bookmark with a new update entry:

See description

Bookmark v1.4 changes:

Improved code to prevent unauthorized viewing of other members bookmark notes by URL manipulation.

Read the rest of this update entry...

 

[AndreaMarucci]

love the simplicity

Eva are you using UI.X as custom skin? I've the same @Chad and @dethfire problem; since I'm using Intrepid from Audentio, the bookmark links are not showing at all...

 

[eva2000]

Eva are you using UI.X as custom skin? I've the same @Chad and @dethfire problem; since I'm using Intrepid from Audentio, the bookmark links are not showing at all...

nope using @Russ pixelexit FLAT Awesome theme with a few modifications of my own

 

[AndreaMarucci]

Thanks. So there's definitely something in Audentio's themes that prevent this from working... I've opened a ticket...

 

[Dad.]

@AndyB in the template modification for post the regular expression you are matching is as follows:

<xen:if is="{$post.canReport}">
                    <a href="{xen:link posts/report, $post}" class="OverlayTrigger item control report" data-cacheOverlay="false"><span></span>{xen:phrase report}</a>
                </xen:if>

Doing this will also check against tab characters. Which means that in theme, such as mine, where I've tabbed in an extra time to keep a clean template, your add-on won't work. The only alternative that I can think of is to match it against just the one line <xen:if> and add the code before that. But I've edited my themes to work with this. Thanks @AndreaMarucci it'll be ready for the next release!

 

[AndreaMarucci]

Thanks to you Mike. I really love @AndyB addons and I really love your theme so it's a pleasure working with both of you

 

[Xon]

@AndyB if you switch from str_replace to the following regular expression replacement type, This will append your bits to the hook, in a way that is compatible with other addons and other themes.

Find:

#(<xen:hook name="post_public_controls".*?)(\s*</xen:hook>)#s

Replace:

$1
<xen:if is="{$visitor.permissions.bookmarkGroupID.bookmarkID}">

<xen:if is="!{$post.bookmark}">
<a href="{xen:link 'posts/bookmark', $post}" class="item control OverlayTrigger">{xen:phrase bookmark_bookmark}</a>
</xen:if>

<xen:if is="{$post.bookmark}">
<a href="{xen:link 'posts/bookmark-unbookmark', $post}" class="item control OverlayTrigger">{xen:phrase bookmark_unbookmark}</a>
</xen:if>

</xen:if>
$2

 

[AndyB]

AndyB updated Bookmark with a new update entry:

See description

Bookmark v1.5 changes:

The Bookmark/Unbookmark link located below the post uses a Template Modification which has been improved by using Regex code. This code improvement makes the Template Modification more likely to work on forums with third party styles.

Read the rest of this update entry...

 

[dotpro]

Andy, thanks for the add-on, very nice.

It is still not working with the UI.X theme.

 

[AndreaMarucci]

AndyB updated

Thanks Andy, now it works halfway since the bookmark link under the message is displayed and working but the link in the user menu (this one)

is not displayed at all. I'll tag also @Mike Creuzer so he knows about that...

 

[AndreaMarucci]

Andy, it seems that the string "Post succesfully bookmarked" is not phrased since I'm not able to find it in phrase search.

Edit: Found sorry

 

[AndyB]

AndyB updated Bookmark with a new update entry:

See description

Bookmark v1.6 changes:

The Bookmark List link located in the Visitor Tab uses a Template Modification which has been improved by using Regex code. This code improvement makes the Template Modification more likely to work on forums with third party styles.

Read the rest of this update entry...

 

[AndreaMarucci]

AndyB updated Bookmark

You're the best, absolutely...

 

[AndreaMarucci]

unfortunately the link doesn't appear in the user menu and, as before, does appear in the default style.

I think @Mike Creuzer should take a look at this issue...

 

[Chad]

love the simplicity thanks !

View attachment 95904

Hey eva, where did you get that My Post tab/mod? Looks good.

AndyB updated Bookmark with a new update entry:

See description



Read the rest of this update entry...

Hi Andy,

Still doesn't show up in the profile tab dropdown, despite being enabled for the usergroup.

The only thing that does show up is the bookmark button in the posts themselves.

 

[Dad.]

unfortunately the link doesn't appear in the user menu and, as before, does appear in the default style.

I think @Mike Creuzer should take a look at this issue...

I have a fix for that in the next release.

 

[AndreaMarucci]

Sounds good

 

[tajhay]

anyone getting any errors?

ErrorException: Fatal Error: syntax error, unexpected ''op' (T_ENCAPSED_AND_WHITESPACE) - library/Andy/SimilarThreads/Model.php:149
Generated By: Unknown Account, 35 minutes ago
Stack Trace
#0 [internal function]: XenForo_Application::handleFatalError()
#1 {main}
Request State
array(3) {
["url"] => string(94) "http://www.xyz.com/threads/thread/page-23"
["_GET"] => array(0) {
}
["_POST"] => array(0) {
}
}

 

[bt012ss]

Hi Andy, ist it possible that this is not phrased ? I cannot find anyone.