Bookmark Essentials [Paid] 3.2.1

[Xon]

Those are fairly large overhauls of the add-on, and while I've got plans for improving bookmarks vs watched threads, I do not have an ETA on when I can start work on something like that

 

[Robert9]

No panic. I just ask and think about. Somehow i have the idea, that i could be a better solution (for me) if a bookmark is just a bookmark, means that i want to collect just links and have lists. I dont like to be reduced to some parts of the forum.

"I collect posts, but no threads. I collect profiles, but no homepages of the same user ..."

Maybe a solution for just anything could be my favorite solution.

This means
a table with title, description, url, prefix, sort
one for cats with title, description, sort
one for linkid/catid

Also a table for lists with title, descr, status, sort

And many icons everywhere to click and save the link behind.

Seems to be an easy story for a weekend, isnt it?

 

[rdn]

On XF 2.1 now, Can I delete this table bookmark_content?
Seems left over from XF 1.5.

Thanks!

 

[Xon]

Once migrated the old 1.x bookmarks, it is safe to drop

 

[Nirjonadda]

@Xon We have lot of bookmark but Most bookmarked contents showing > No items have been created yet.

 

[Xon]

Probably the query being buggy, will look into it.

 

[Nirjonadda]

@Xon One more issue with @Ehren Uniform style. Like button and Bookmark button does not have margin or space for profile posts.

 

[Nirjonadda]

@Xon How to disable Recent bookmarks count from Forum statistics? Please can you add enable/disable option for Recent bookmarks count from Forum statistics?

 

[Sunka]

@Xon
Some errors. I will tag also @AddonsLab because their addon is related in error too.

Server error log
ErrorException: Template error: Method canTriggerCacheUpdate is not callable on the given object (SV\BookmarkEssentials\XF\Entity\Post) src/XF/Template/Templater.php:999
Generated by: Unknown account 11.11.2019. at 21:27
Stack trace
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Method canTrigg...', '/home/nginx/dom...', 999, Array)
#1 src/XF/Template/Templater.php(999): trigger_error('Method canTrigg...', 512)
#2 internal_data/code_cache/templates/l1/s1/public/post_macros.php(467): XF\Template\Templater->method(Object(SV\BookmarkEssentials\XF\Entity\Post), 'canTriggerCache...', Array)
#3 src/XF/Template/Templater.php(706): XF\Template\Templater->{closure}(Object(SV\BookmarkEssentials\XF\Template\Templater), Array, Array)
#4 internal_data/code_cache/templates/l1/s1/public/thread_view.php(661): XF\Template\Templater->callMacro('post_macros', 'post', Array, Array)
#5 src/XF/Template/Templater.php(1320): XF\Template\Templater->{closure}(Object(SV\BookmarkEssentials\XF\Template\Templater), Array)
#6 src/addons/AddonsLab/GuestPosting/XF/Template/Templater.php(67): XF\Template\Templater->renderTemplate('thread_view', Array, true)
#7 src/XF/Template/Template.php(24): AddonsLab\GuestPosting\XF\Template\Templater->renderTemplate('public:thread_v...', Array)
#8 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#9 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Html->renderView('XF:Thread\\View', 'public:thread_v...', Array)
#10 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#11 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#12 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#13 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#14 src/XF.php(391): XF\App->run()
#15 index.php(20): XF::runApp('XF\\Pub\\App')
#16 {main}
Request state
array(4) {
  ["url"] => string(50) "/threads/opcenito-o-rolama-savjeti-i-iskustva.701/"
  ["referrer"] => string(23) "https://www.google.com/"
  ["_GET"] => array(1) {
    ["/threads/opcenito-o-rolama-savjeti-i-iskustva_701/"] => string(0) ""
  }
  ["_POST"] => array(0) {
  }
}

 

[Xon]

None of my add-ons add or use the method canTriggerCacheUpdate, so it is likely a bug in another add-on.

 

[Nirjonadda]

@Sunka I am also getting same Server error logs. Do you find out what add-on happened this Server error logs?

ErrorException: Template error: Method canTriggerCacheUpdate is not callable on the given object (SV\BookmarkEssentials\XF\Entity\Post) src/XF/Template/Templater.php:999

 

[Sunka]

@Sunka I am also getting same Server error logs. Do you find out what add-on happened this Server error logs?

ErrorException: Template error: Method canTriggerCacheUpdate is not callable on the given object (SV\BookmarkEssentials\XF\Entity\Post) src/XF/Template/Templater.php:999

Nop, but there is not any more errors in my server logs except those from few days ago.

If I know the steps to recreate those errors, I could disable addons one by one to find which one is conflicted

 

[Nirjonadda]

@Xon Getting Server error log.

LogicException: Cannot save with validation errors. Use validate() to ensure there are no errors. (First error: Please enter a value for the required field 'content_user_id'.) src/XF/Service/ValidateAndSavableTrait.php:34

Generated by: Interstellar Dec 2, 2019 at 8:46 AM

Stack trace

#0 src/addons/SV/BookmarkEssentials/XF/Entity/BookmarkItem.php(35): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->save()
#1 src/XF/Mvc/Entity/Entity.php(1584): SV\BookmarkEssentials\XF\Entity\BookmarkItem->_postDelete()
#2 src/XF/ControllerPlugin/Bookmark.php(179): XF\Mvc\Entity\Entity->delete()
#3 src/XF/ControllerPlugin/Bookmark.php(23): XF\ControllerPlugin\Bookmark->actionSaveBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/44328/bo...')
#4 src/XF/Pub/Controller/Post.php(358): XF\ControllerPlugin\Bookmark->actionBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/44328/bo...')
#5 src/XF/Mvc/Dispatcher.php(350): XF\Pub\Controller\Post->actionBookmark(Object(XF\Mvc\ParameterBag))
#6 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass('XF:Post', 'Bookmark', Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#7 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#8 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#9 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#10 src/XF.php(391): XF\App->run()
#11 index.php(20): XF::runApp('XF\\Pub\\App')
#12 {main}

Request state

array(4) {
  ["url"] => string(21) "/posts/44328/bookmark"
  ["referrer"] => string(33) "/threads/6/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(5) {
    ["_xfToken"] => string(8) "********"
    ["delete"] => string(9) "undefined"
    ["_xfRequestUri"] => string(11) "/threads/6/"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[Xon]

Xon updated Bookmark Essentials with a new update entry:

3.0.4 - Bugfix update

• Fix error deleting/adding bookmarks on guest posts

Read the rest of this update entry...

 

[Nirjonadda]

@Xon getting one more Server error log.

InvalidArgumentException: Attempted to convert NULL to integer [first_bookmarked_on] src/XF/Mvc/Entity/Entity.php:740

Generated by: Son Goku Dec 6, 2019 at 8:18 PM

Stack trace

#0 src/XF/Mvc/Entity/Entity.php(618): XF\Mvc\Entity\Entity->_castValueToType(NULL, 'first_bookmarke...', 2, Array)
#1 src/XF/Mvc/Entity/Entity.php(720): XF\Mvc\Entity\Entity->set('first_bookmarke...', NULL, Array)
#2 src/addons/SV/BookmarkEssentials/Entity/BookmarkContentStat.php(216): XF\Mvc\Entity\Entity->bulkSet(Array)
#3 src/XF/Mvc/Entity/Entity.php(1297): SV\BookmarkEssentials\Entity\BookmarkContentStat->_preSave()
#4 src/addons/SV/BookmarkEssentials/Service/BookmarkContent/StatAdjuster.php(97): XF\Mvc\Entity\Entity->preSave()
#5 src/XF/Service/ValidateAndSavableTrait.php(17): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->_validate()
#6 src/XF/Service/ValidateAndSavableTrait.php(31): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->validate(NULL)
#7 src/addons/SV/BookmarkEssentials/XF/Entity/BookmarkItem.php(35): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->save()
#8 src/XF/Mvc/Entity/Entity.php(1584): SV\BookmarkEssentials\XF\Entity\BookmarkItem->_postDelete()
#9 src/XF/ControllerPlugin/Bookmark.php(179): XF\Mvc\Entity\Entity->delete()
#10 src/XF/ControllerPlugin/Bookmark.php(23): XF\ControllerPlugin\Bookmark->actionSaveBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/28087/bo...')
#11 src/XF/Pub/Controller/Post.php(358): XF\ControllerPlugin\Bookmark->actionBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/28087/bo...')
#12 src/XF/Mvc/Dispatcher.php(350): XF\Pub\Controller\Post->actionBookmark(Object(XF\Mvc\ParameterBag))
#13 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass('XF:Post', 'Bookmark', Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#14 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#15 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#16 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#17 src/XF.php(391): XF\App->run()
#18 index.php(20): XF::runApp('XF\\Pub\\App')
#19 {main}

-------------

Previous InvalidArgumentException: Attempted to convert NULL to integer - src/XF/Mvc/Entity/ValueFormatter.php:141
#0 src/XF/Mvc/Entity/Entity.php(736): XF\Mvc\Entity\ValueFormatter->castValueToType(NULL, 2, Array)
#1 src/XF/Mvc/Entity/Entity.php(618): XF\Mvc\Entity\Entity->_castValueToType(NULL, 'first_bookmarke...', 2, Array)
#2 src/XF/Mvc/Entity/Entity.php(720): XF\Mvc\Entity\Entity->set('first_bookmarke...', NULL, Array)
#3 src/addons/SV/BookmarkEssentials/Entity/BookmarkContentStat.php(216): XF\Mvc\Entity\Entity->bulkSet(Array)
#4 src/XF/Mvc/Entity/Entity.php(1297): SV\BookmarkEssentials\Entity\BookmarkContentStat->_preSave()
#5 src/addons/SV/BookmarkEssentials/Service/BookmarkContent/StatAdjuster.php(97): XF\Mvc\Entity\Entity->preSave()
#6 src/XF/Service/ValidateAndSavableTrait.php(17): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->_validate()
#7 src/XF/Service/ValidateAndSavableTrait.php(31): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->validate(NULL)
#8 src/addons/SV/BookmarkEssentials/XF/Entity/BookmarkItem.php(35): SV\BookmarkEssentials\Service\BookmarkContent\StatAdjuster->save()
#9 src/XF/Mvc/Entity/Entity.php(1584): SV\BookmarkEssentials\XF\Entity\BookmarkItem->_postDelete()
#10 src/XF/ControllerPlugin/Bookmark.php(179): XF\Mvc\Entity\Entity->delete()
#11 src/XF/ControllerPlugin/Bookmark.php(23): XF\ControllerPlugin\Bookmark->actionSaveBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/28087/bo...')
#12 src/XF/Pub/Controller/Post.php(358): XF\ControllerPlugin\Bookmark->actionBookmark(Object(SV\BookmarkEssentials\XF\Entity\Post), '/posts/28087/bo...')
#13 src/XF/Mvc/Dispatcher.php(350): XF\Pub\Controller\Post->actionBookmark(Object(XF\Mvc\ParameterBag))
#14 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass('XF:Post', 'Bookmark', Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#15 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(TickTackk\ChangeContentOwner\XF\Pub\Controller\Post), NULL)
#16 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#17 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#18 src/XF.php(391): XF\App->run()
#19 index.php(20): XF::runApp('XF\\Pub\\App')
#20 {main}

Request state

array(4) {
  ["url"] => string(21) "/posts/28087/bookmark"
  ["referrer"] => string(36) "/search/84053/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(5) {
    ["_xfToken"] => string(8) "********"
    ["delete"] => string(9) "undefined"
    ["_xfRequestUri"] => string(14) "/search/84053/"
    ["_xfWithData"] => string(1) "1"
    ["_xfResponseType"] => string(4) "json"
  }
}

 

[Libertis]

@Xon does this show the bookmarks of a user publicly like a favorites list. I would like to have something that shows your bookmarks to other users on their profile. not sure this addon does it. thanks

 

[Erel]

I've upgraded to Xenforo 2 and installed this add-on.
I'm now seeing these errors in the logs:

• Template error: Template public:news_feed_item_post_bookmark is unknown

#0 [internal function]: XF\Template\Templater->handleTemplateError(512, 'Template public...', '/home/basicap/p...', 618, Array)
#1 src/XF/Template/Templater.php(618): trigger_error('Template public...', 512)
#2 src/XF/Template/Templater.php(566): XF\Template\Templater->getTemplateData('public', 'news_feed_item_...')
#3 src/XF/Template/Templater.php(1314): XF\Template\Templater->getTemplateCode('public', 'news_feed_item_...')
#4 src/XF/NewsFeed/AbstractHandler.php(102): XF\Template\Templater->renderTemplate('news_feed_item_...', Array)
#5 src/XF/Entity/NewsFeed.php(79): XF\NewsFeed\AbstractHandler->render(Object(XF\Entity\NewsFeed))
#6 [internal function]: XF\Entity\NewsFeed->render()
#7 src/XF/Template/Templater.php(999): call_user_func_array(Array, Array)
#8 internal_data/code_cache/templates/l1/s1/public/news_feed_macros.php(34): XF\Template\Templater->method(Object(XF\Entity\NewsFeed), 'render', Array)
#9 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\BookmarkEssentials\XF\Template\Templater), Array, Array)
#10 internal_data/code_cache/templates/l1/s1/public/news_feed_macros.php(14): XF\Template\Templater->callMacro('news_feed_macro...', 'feed_item', Array, Array)
#11 src/XF/Template/Templater.php(701): XF\Template\Templater->{closure}(Object(SV\BookmarkEssentials\XF\Template\Templater), Array, Array)
#12 internal_data/code_cache/templates/l1/s1/public/member_latest_activity.php(34): XF\Template\Templater->callMacro('news_feed_macro...', 'feed_row', Array, Array)
#13 src/XF/Template/Templater.php(1315): XF\Template\Templater->{closure}(Object(SV\BookmarkEssentials\XF\Template\Templater), Array)
#14 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('member_latest_a...', Array)
#15 src/XF/Mvc/Renderer/Html.php(48): XF\Template\Template->render()
#16 src/XF/Mvc/Dispatcher.php(458): XF\Mvc\Renderer\Html->renderView('XF:Member\\Lates...', 'public:member_l...', Array)
#17 src/XF/Mvc/Dispatcher.php(440): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#18 src/XF/Mvc/Dispatcher.php(400): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#19 src/XF/Mvc/Dispatcher.php(58): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#20 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#21 src/XF.php(391): XF\App->run()
#22 index.php(20): XF::runApp('XF\\Pub\\App')
#23 {main}

 

[Xon]

Can you run this SQL, it'll remove the old bookmark news feed items;

delete from xf_news_feed where content_type ='post' and action ='bookmark';

 

[Erel]

Can you run this SQL, it'll remove the old bookmark news feed items;

It fixed the issue. Thank you!

 

[Xon]

Xon updated Bookmark Essentials with a new update entry:

3.0.5 - Bugfix update

• Fix XF1 import error where the bookmark date is imported as the message, if the bookmark_content table still exists, the message is copied over

Read the rest of this update entry...