Fixed Birthday widget not showing some users

[CFMack]

I enabled the Today's birthdays widget in Forum list: Sidebar, position 1. A member's birthday is today, however the widget is not showing up.

 

[Chris D]

Their DOB may not be public.

 

[CFMack]

According to their preferences in the ACP:

 

[Ozzy47]

Does the cron run at midnight to populate the widget?

 

[CFMack]

I just ran a few of them.

This is what the template looks like:

 

[Chris D]

Does the cron run at midnight to populate the widget?

It doesn’t use a cron.

I just ran a few of them.

This is what the template looks like:

View attachment 174622

Do they appear under Birthdays under the Notable members section?

 

[CFMack]

Yes, they do.

 

[Chris D]

I’ll check the code but as far as I recall it should be the same.

So I can only suggest trying to move the widget to other positions to see if that makes it show.

Also try it on an unedited default XF style.

 

[CFMack]

Okay. I did try to move it to other positions, and even different positions within Forum list: Sidebar.

Thanks, Chris.

 

[Chris D]

There's a bug!

 

[Chris D]

Just fixed it, if you'd like to patch it yourself, you need to edit src/XF/Widget/Birthdays.php.

Find:

$userFinder = $this->finder('XF:User')
   ->isBirthday()
   ->isValidUser(true)
   ->order('username');

Replace with:

$userFinder = $this->finder('XF:User')
   ->isBirthday()
   ->isRecentlyActive(365)
   ->isValidUser()
   ->order('username');

The previous code was applying a "recently active" constraint of 180 days. We had changed it to 365 days for the member stat, but must have missed it from the Widget.

 

[CFMack]

That did it. Thanks, Chris!

 

[CFMack]

Chris, will this go away for the next XF update?

 

[Chris D]

Yes it will. Won't be too long until the next release.