[bd] Tag Me for XenForo 1.3 3.2.0

[MattW]

It's the latest update to Responsive Design (1.1.0) that is breaking the Tag mod.

 

[Arty]

Its a bug in this add-on. When it checks for template name, it does strict check without considering that class attribute might contain additional class names.

In tinymce_plugin.js replace

                    if (pageTemplateTitle == XenForo.bdTagMe_enabledTemplates[i]) {

with

                    if (pageTemplateTitle.indexOf(XenForo.bdTagMe_enabledTemplates[i]) >= 0) {

 

[Arty]

or better yet, replace it with

                    if ($pageContentNode.hasClass(XenForo.bdTagMe_enabledTemplates[i])) {

and then delete this line few lines above

                var pageTemplateTitle = $pageContentNode.attr('class');

 

[Rho Delta]

Ooh please release a hotfix

 

[MattW]

Its a bug in this add-on. When it checks for template name, it does strict check without considering that class attribute might contain additional class names.

In tinymce_plugin.js replace

                    if (pageTemplateTitle == XenForo.bdTagMe_enabledTemplates[i]) {

with

                    if (pageTemplateTitle.indexOf(XenForo.bdTagMe_enabledTemplates[i]) >= 0) {

Yep, this has fixed it. Had to do it in both files (including the one in the full folder as well)

 

[Kerby]

When i tag our admin group "@Administrator", then its linked to /members/administrator.0/. "@Moderator" is linked to /members/moderator.0/.

When I click on the links, my browser opens a xenforo error page under page "members" with text: "This was posted by a guest who does not have a profile to view."

It should better show all members of tagged group in a overlay, like it does at a post with more than 4 likes, if you know what i mean. i can post a screenshot if needed to understand how it should work.

 

[rdn]

When i tag our admin group "@Administrator", then its linked to http://swisssmp.ch/members/administrator.0/. "@Moderator" is linked to http://swisssmp.ch/members/moderator.0/.

When I click on the links, my browser opens a xenforo error page under page "members" with text: "This was posted by a guest who does not have a profile to view."

It should better show all members of tagged group in a overlay, like it does at a post with more than 4 likes, if you know what i mean. i can post a screenshot if needed to understand how it should work.

Administrator and Moderator when tag has no link, cannot be click.

 

[Kerby]

@Evina, on my website, it's tagged AND has mentioned link (= is clickable).

Probably you haven't set in usergroup "administrator" the option checkbox to be tagable?

 

[rdn]

@Evina, on my website, it's tagged AND has mentioned link (= is clickable).

Probably you haven't set in usergroup "administrator" the option checkbox to be tagable?

Are you using the latest version?
It's not clickable on mine.
I enable admin/mods to be tagable.

 

[Kerby]

i'm using 1.6.5.

 

[xfrocks]

or better yet, replace it with

                    if ($pageContentNode.hasClass(XenForo.bdTagMe_enabledTemplates[i])) {

and then delete this line few lines above

                var pageTemplateTitle = $pageContentNode.attr('class');

Thansk Arty, nice fix. This will be included in the next update.

When i tag our admin group "@Administrator", then its linked to http://swisssmp.ch/members/administrator.0/. "@Moderator" is linked to http://swisssmp.ch/members/moderator.0/.

When I click on the links, my browser opens a xenforo error page under page "members" with text: "This was posted by a guest who does not have a profile to view."

It should better show all members of tagged group in a overlay, like it does at a post with more than 4 likes, if you know what i mean. i can post a screenshot if needed to understand how it should work.

The original admin and mod user group is "Administrative" and "Moderating". Are you using user groups imported from vBulletin? Anyway, user group tagging should become a clickable link with a popup as you described. The link goes to http://domain.com/xenforo/members/tagged/user_group/3

 

[melbo]

Thansk Arty, nice fix. This will be included in the next update.

Great! When do you think we'd see this update (or should I make the edits in .js manually?)

 

[MOZ]

Hey xfrocks, would it be possible for you to render the links via the username helper?

 

[xfrocks]

xfrocks updated [bd] Tag Me with a new update entry:

Now with email when you are tagged!

Version 1.7 (released Feb 23, 2013)
1.7/1 Fix compatibility issue with Responsive Design 1.1.0
1.7/2 Use username helper to render user link
1.7/3 Add tag group permission
1.7/4 Add sending email option

Read the rest of this update entry...

 

[xfrocks]

Hey xfrocks, would it be possible for you to render the links via the username helper?

Check out the latest version, it does just that!

 

[xfrocks]

Great! When do you think we'd see this update (or should I make the edits in .js manually?)

It is included in the latest version (v1.7)

 

[Andy.N]

It is included in the latest version (v1.7)

I can't seem to be able to tag anymore from the quick reply box.
@xfroc... wouldn't popup the name picker.

 

[xfrocks]

I can't seem to be able to tag anymore from the quick reply box.
@xfroc... wouldn't popup the name picker.

Post anyway with a correct name to verify the tagging please?
Your javascript may be cached, try refreshing too.

 

[Andy.N]

Post anyway with a correct name to verify the tagging please?
Your javascript may be cached, try refreshing too.

Yes, the @xfrocks after posting will work, but not while it's being posted.
I'll watch to see if it shows up later as all my JS are cdn cached by cloudfront.

 

[xfrocks]

Yes, the @xfrocks after posting will work, but not while it's being posted.
I'll watch to see if it shows up later as all my JS are cdn cached by cloudfront.

In the meantime, test the emails then