Fixed BB Code Media Sites incorrectly converts spaces in media IDs to + signs instead of %20

[Optic]

I'm attempting to create a custom BB Code Media Site for self hosted videos using FlowPlayer.

My intention is to use the filename as the media ID for {$id}

<div class="flowplayer">
   <video>
      <source type="video/mp4"  src="http://test.com/flowplayer/{$id}">
   </video>
</div>

The problem is if I include any spaces within the media ID BBCode, it incorrectly converts the spaces to + signs instead of %20, so the resulting video will never embed correctly as it's the wrong URL.

Thinking maybe the Flowplayer embed code was at fault, I tried removing the Flowplayer code altogether and just put the URL of the video in the Embed HTML but with the same effect.


Steps to reproduce:
1. Create BB Code Media Site:


2. Create a post with the new media BB code and include spaces in the media ID:


3. The filename is incorrectly embedded with + signs instead of %20 in the message body:


The correct URL is supposed to be:
http://test.com/flowplayer/Angel Beats - OP.mp4

 

[Jeremy]

This is standard PHP functionality, urlencode() uses + signs and rawurlencode() uses %20, a different standard.

 

[Optic]

I see... is there any workaround for that?

Otherwise I suppose I could remove the spaces in my filenames as a last resort...

 

[Mike]

+ is a valid encoding in a URL as a space. This is me searching Google for "test search"

https://www.google.co.uk/search?q=test+search

Of course https://www.google.co.uk/search?q=test search works as well.

However, this may be specific to query strings and the actual URL body may need %20 (which is valid in the query strign as well), so it may be worth changing.

 

[Mike]

I've adjusted this to use rawurlencode as that should be safe for all case. (While I'm at it, I've changed the URL "prettifying" code in posts to use rawurlencode as well so + is kept. This appears to be consistent with how Chrome itself displays URLs when you hover them.)