Fixed Authors Response - Option To Delete Appears Even If User Does Not Have Permission

[Divvens]

The user does not have permission to delete anything (regular user, not a moderator) however the delete option appears below the "Authors Response" - when clicked, it brings up an error saying the user does not have permission.

Note, this only appears on the "Latest Reviews" page \ https://xenforo.com/community/resources/reviews

Do I need to fix my permissions somewhere? Or is there a way to hide that delete button?

 

[Mike]

If this is only appearing on one page, it's probably a bug. Will move it there for analysis.

 

[Divvens]

If this is only appearing on one page, it's probably a bug. Will move it there for analysis.

It only appears on reviews left by the member viewing (and if it has an authors response).

Steps;
1 - Leave a review
2- Have the author response
3- When visiting the latest reviews page it'll show an option to delete the authors response, however when clicked gives an error overlay.

Just if you needed more information.

 

[Mike]

This is fixed now thanks. It's just a display bug, but if you want to fix it, in library/XenResource/Model/Rating.php, replace:

        return (
            $resource['user_id'] == $viewingUser['user_id']
            || XenForo_Permission::hasContentPermission($categoryPermissions, 'deleteReviewAny')
        );

With:

        $userId = isset($resource['resource_user_id']) ? $resource['resource_user_id'] : $resource['user_id'];

        return (
            $userId == $viewingUser['user_id']
            || XenForo_Permission::hasContentPermission($categoryPermissions, 'deleteReviewAny')
        );