• This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn more.

Fixed Amazon.fr links do not convert to page titles correctly

#1
Most Amazon links won't convert (my old addon had no issues with that for some reason).
Examples:

http://www.amazon.fr/Microsoft-5C5-..._2?s=videogames&ie=UTF8&qid=1448616321&sr=1-2

http://www.amazon.fr/gp/product/B0187QS1CC?ref_=gb1h_tit_m-4_9187_f816301f&smid=A1X6FK5RDHNB96

http://www.amazon.fr/Tommy-Hilfiger...words=Tommy+Hilfiger+-+1790708+-+Montre+Homme

Being the largest site on the internet, I think that we should find a solution. It's really annoying to go and edit all posts links when there is Amazon in it.

Other examples:
https://www.ryanair.com/fr/fr/
 

Mike

XenForo developer
Staff member
#2
This is fixed now. It might be a temporary change by Amazon for Black Friday/the holidays, but the issue was that their title tag was approximately 20KB into the HTML of the page. We weren't looking quite that far for the tag.

As for Ryanair, their site actually has no title in the HTML. It only gets one via JS. Nothing can be done there.
 

Kevin

Well-known member
#3
This is fixed now. It might be a temporary change by Amazon for Black Friday/the holidays, but the issue was that their title tag was approximately 20KB into the HTML of the page. We weren't looking quite that far for the tag.
Mike, is the fix for Amazon in general? I've been having the same issue with Amazon.com not grabbing the title.
 

HWS

Well-known member
#5
Amazon is known to bury the title deep into their html. The default amount of data checked (for performance not the whole page is checked for it, but only the first lines of code) is simply not sufficient for such cases.

Looks like this limit has been raised.
 
#6
This wasn't related to Black Friday. I've been having this issue with Amazon and a few other sites ever since the feature was released.

@Mike how to I implement the fix?

I just tried on my forums, still the same, no change, the page title doesn't show.
 
#9
The fix will be available in the next release.
Ok, now I understand. The "fixed" prefix mislead me.
Hope the new version will come up soon, according to the typical XF schedule it should be soon, shouldn't it? :)

In the meantime, would there be some type of hotfix or someone to show what we could do to fix it? (just in case the next release would be not this year)
If it's only a limit increase, maybe those interested would just do it on their own.
 

Mike

XenForo developer
Staff member
#10
It won't be too long until there's a release with the fix, but you can edit library/XenForo/BbCode/Formatter/BbCode/AutoLink.php and change the line:
Code:
XenForo_HttpStream::setMaxSize(20 * 1024); // 20KB
Change the 20 to a 50.