I just hopped on my laptop and unfortunately, XF23 sorting seems to be broken since XF 2.3x, not sure if it's a recent thing or not. I tested with XF 2.3.5
I can use other anti-adblocking tools to disrupt their use of the site and encourage them to whitelist or subscribe.
This would be very helpful.
I was mistaken, as of the recent versions of this add-on sorting DOES work as expected.
This is not working for me.
Still doesn't work for me but I have other addons that are probably the culprit. We can address it later if/when other people have the same combination of addons that causes the issue. In the meantime, I need to do a manual refresh any time somebody upgrades.
You're right, this issue actually isn't fixed.
He made an update and it appeared to be working for me - but it was short-lived. I think it would be great to have the addon automatically do a refresh after an account upgrade. Though that may not be possible. In fact, I think he may have addressed this somewhere in the discussion... But that would ultimately fix the issue for good.You're right, this issue actually isn't fixed.
The User is added to the subscribed group but remains in the AdBlocking group and the status 'you need xx pageviews to move out of the group' is not updated
<?php
namespace Wutime\AdBlockTracker\XF\Service\User;
class UserGroupChange extends XFCP_UserGroupChange
{
public function addUserGroupChange($userId, $changeKey, $groupId, $endDate = null)
{
$options = \XF::options();
$AdBlockUserGroupId = $options->wutime_tracker_detected_assign_role;
$ignoreRoles = $options->wutime_tracker_detected_ignore_roles;
if ($AdBlockUserGroupId) {
// Check if the groupId is one of the roles you want to trigger this logic
if (in_array($groupId, $ignoreRoles)) {
$detected = \XF::repository('Wutime\AdBlockTracker:Detected')->findOneByUserId($userId);
if ($detected) {
$detected->delete();
}
}
}
parent::addUserGroupChange($userId, $changeKey, $groupId, $endDate);
}
} protected function _preDelete()
{
if ($this->status=='AdBlocking') {
// remove adblocking role prior to delete
$userGroupChange = \XF::service('XF:User\UserGroupChange');
$userGroupChange->removeUserGroupChange($this->user_id, 'AdBlockDetected');
$this->rebuildUserGroupCacheForUser($this->user_id);
}
}