Fixed 404 urls cause unfurl.php to loop constantly

[Naz]

Affected version

2.1

To reproduce:

1. Post or preview a post that contains a link that leads to a 404
2. Observe unfurl.php looping constantly

My tests have been unscientific but I was able to trigger similar behaviour with a link on one line and markdown on the next but can't seem to reproduce that one anymore.

https://xenforo.com/community/threads/zxybdeybd7

 

[Chris D]

They shouldn’t loop connstantly for sure but we do count errors and stop attempting to fetch them beyond 3 errors so that is probably what you’re hitting.

 

[Rhodium]

I can confirm this loop if you press preview two times with any url. First preview is fine, then loop.

 

[KSA]

I can confirm this as well. Second hit then loop non stop.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved.

Change log:

Remove pending unfurls once completed

Any changes made as a result of this issue being resolved may not be rolled out here until later.