1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Won't Fix 2FA Setup Methods Redundant?

Discussion in 'Resolved Bug Reports' started by Liam W, Jul 15, 2016.

  1. Liam W

    Liam W Well-Known Member

    In the two-factor system, setup is done using the standard validation methods and the context parameter, which makes the requiresSetup method and other setup methods in the abstract class redudant and confusing.

    (Also, there is some code related to this setup in the controller, but it doesn't actually appear to render anything).

    Liam
     
    Last edited: Jul 15, 2016
  2. Mike

    Mike XenForo Developer Staff Member

    I don't disagree with you. It's a vestige of some refactoring that happened during development. However, I believe there is some code paths that could still be triggered, so it's not something that I would remove at this point. It will be something that's cleaned up when a BC break isn't a problem (hint hint ;)).
     
    NixFifty, Steve F, Liam W and 2 others like this.

Share This Page