Search Improvements 2.17.2

• During upgrades, fix " Access to undeclared static property " error.
• Do not show the "Tags will be searched" tooltip as part of "Search titles only" in advanced search for content types which do not implement tagging

Thanks for @NamePros for funding this update.

• Improve how thread/tickets by others in a category without view-other permission are filtered out of search results when using XFES without ElasticSearch Essentials
• Add PermissionConstraint helper class, designed to simplify implementing XF Search handler's getTypePermissionConstraints function
• Add "Collect search DSL & debug statistics" option (Default off), designed as a developer tool and strongly not recommended for production usage.

• Cleanup add-on description & readme file
• Update XFES dependent option descriptions to include if they require XFES
• Improve styling of 'no results' search result in an overlay
• Fix search result terms do not display when search results are in an overlay
• Fix custom styling triggering "Your changes have been saved." when clicking a member search link

• Fix "Push "View X by others" option being disabled would cause some user information to not be indexed, which had the implicit "rebuild search index" if this setting was then enabled.
  • This fixed conversation search when using Conversation Improvements v2.4.x+
  • Requires a re-index of at least conversations/conversation messages to re-add the missing information.
  • For most sites, disabling the "Push "View X by others" check into XFES" option is not recommended

• Fix error "Object of class XF\Mvc\Reply\View could not be converted to string" when a user is denied search tries to use search

• Workaround XF bug where a search type parameter was not validated as being allowed for a search handler
• Workaround XF bug where a search could be constructed which targeted the parent (ie thread) content type and not the child (ie post) content type resulting in potentially degraded search results
• Replace search/member search with a redirect to a standard search with the appropriate parameters entered. Stock XF member searches are slightly specialized and the general search is missing several features to support normal search being a strict super-set of member search.
  • XF lacked a "search only X" per search tab that this add-on injects
  • XF would target the parent type and didn't figure out the child type
• Force a search without a query string to render it as * which allows member searches to be edited/refined
• Redirect to XFES configuration page if XFES isn't configured instead of the search index list
• Show basic statistics on the search index list page

• Fix additional XFES index page would show even when XFES was not installed/active

Thanks to @NamePros for sponsoring this update.
This add-on is now available on atelieraphelion.com

This update will require a full search rebuild, truncating the index before re-indexing.

• Require Standard Library by Xon v1.18.0+
• Workaround for XF bug where the search URL did not contain the various query string arguments, causing issues when the URL was shared
• Workaround for XF bug where the search ownership check wasn't strict enough
• Workaround for XF bug where a user's recent content had a "view more" link which rendered even if the visitor didn't have permission to search
• Move some permission handling code into StandardLib so it has a common hook point
• Fix edge case where XFES is installed by not enabled causing XFES-only code-paths to be triggered
• Fix reporting search terms without phrases on the results page return false positives
• Fix various search result terms missing phrases, bad rendering of links
• Fix pushing viewable ticket category constraints into ElasticSearch for NixFifty's Tickets add-on
• Search result terms are now sorted to pull known important bits first
• Add various helper functions & template macros for writing search criteria
• Improvements which require ElasticSearch (aka Xenforo Enhanced Search)
  • Support for ElasticSearch Essential's "container only" search term result criteria
  • Tickets:
    • Search by min/max number of replies, sort by number of replies
    • Search by ticket participants

• Fix searching by member without a keyword for a guest

Thanks @NamePros for sponsoring this update

• Fix cached search results would be unexpectedly be viewable to anyone if they guessed the search result URL.
  • Affected versions; v2.8.1
  • These search URLs expire after a day
• Fix search term on search result pages leaking information for non-viewable content
  • Affected version; v2.7.4, v2.7.5 and v2.8.1
  • Fix leaking thread title when using "In thread" search area, and rendering a bad phrase if the thread doesn't exist
  • Fix linking to non-active user profiles when searching by members
• Workaround for an XF bug where the cached search results for a member search could be directly shared with a guest
  • Non-visible items on the result page where not rendered, but this does leak that there are hits in not viewable to guests areas.