Recent content by Jonathan M

In the profile_post_macros template, the comment macro is missing <xf:css src="message.less" />. This is necessary for the profile post comment to display correctly on the /profile-posts/comments/1/show page.

Steps to reproduce 1) Either visit [thread]/poll/create directly or open the thread view's 'create poll' link in a new tab. 2) Fill the form and submit. 3) The page will submit to itself, creating the poll, but will then redirect to itself and display a no permission error. This happens because...

No, this issue doesn't actually cause a problem after the user submits the form. I don't think the issue is present in Select2 though, at least, based on the examples on this page.

Found a few others... option_explain.emailWatchedThreadIncludeMessage is missing an 's' on the first instance of 'forum'. style_prop_desc.fixedMessage is missing a period at the end.

XF\Mvc\Entity\FinderCollection extends XF\Mvc\Entity\AbstractCollection which implements ArrayAccess. This means FinderCollection should throw an exception when attempting to access non-existent keys but it just returns null instead. Since it's implementing ArrayAccess, it should behave the same...

The phrase 'widget_def_desc.forum_statistics' reads 'Displays a block which that shows the forum's current statistics on things like total discussions, message and member count.' The 'which that' is unfinished. The sentence should only include one of those, not both.

Validation in token inputs is broken in 2 related but different ways. Replication steps: Open a thread. Press the edit tags icon. Press comma twice. This will insert a comma tag which should be disallowed because a comma plus spaces is the delimiter for token inputs. Replication steps: Open...

In the button macro in the multi_quote_macros template, 'arg-addMessage' and 'arg-removeMessage' are accepted. They also have default values set. <xf:macro name="button" arg-href="!" arg-messageSelector="!" arg-storageKey="!" arg-addMessage="{{ phrase('multiquote_add_message')...