Fixed XFRM\Service\ResourceItem\Icon::setImageFromExisting does not fail as expected if the icon is missing

[Xon]

Affected version

2.3.3

public function setImageFromExisting(): bool
{
    $path = $this->resource->getAbstractedIconPath();
    if (!$this->app->fs()->has($path))
    {
        new \InvalidArgumentException(
            "Resource does not have an icon ({$path})"
        );
    }

There is no throw on that new \InvalidArgumentException line

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XFRM release (2.3.4).

Change log:

Fix failure to throw exception when existing resource icon cannot be loaded

There may be a delay before changes are rolled out to the XenForo Community.