Fixed XF\BbCode\Renderer\Html::renderTag redundant $options mutation operations

[Xon]

Affected version

2.1.1

renderTag decrements $options['stopSmilies'] and $options['stopBreakConversion'] at the end, despite $options being a copy-on-write (ie not pass by preferences) meaning the changes are discarded when the function returns.

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.2).

Change log:

Remove unused code from BB code tag renderer.

Any changes made as a result of this issue being resolved may not be rolled out here until later.