Not a bug XF 2.3.6 Templater Modification bug with .less modifications

[Wutime]

Affected version

2.3.6

I've come across a strange bug whereby a template modification wants to add an extra curly brace for no apparent reason. These template modifications worked previously, and I've even gone so far as to replicate what XMFG does with it's core.less, but to no avail, the bug persists.

This bug persists across other similar .less template modifications that I've used in the past. The issue seems to lie in the fact of the save removing a line return, hence why the first "test" passes, and the following "test" fails, adding the additional unwanted curly brace.

View attachment bug-issue-templater.mov

 

[Chris D]

You showed two different template modifications there.

The first one, the replacement looks like this:

<empty line>
{{ include('your_template') }}
<empty line>

The second one your replacement looks like this:

{{ include('your_template') }}
<empty line>

There is no extra curly brace in either case, it's just an artefact of how the Diff calculates the different replacements you have specified (one with an empty line, one without).

Note that in the second one the Diff says it is removing } but on the next line where the include is, it's prefixed with a } so, again, no extra } it's just how the diff calculates.

There's no bug here. Both template modifications are valid and will work as intended.

 

[Wutime]

Okay apologies. I had a customer reporting a .less template was adding an additional curly brace, and then when I got to figuring out why came upon this which seemed to explain it.

 

[Wutime]

Oh, silly me, I see what you mean now. It's literally removing } and then re-adding }

Doh