Fixed XenForo tries to send push notifications to invalid URLs

Kirby

Well-known member
Affected version
2.3.7
I havn't found a definitive reference for this yet, but it seems that Chrome / Chromium sometimes generates placeholder URLs starting with https://permanently-removed.invalid/fcm/send for invalid / expired push subscriptions, see https://xenforo.com/community/threads/push-notification-failure-curl-error-6.234166

XenForo currently accepts those URLs and tries to send notifications there which obviously fails and kinda floods the error log if those endpoints are utilized frequently (which happened to us yesterday).

Suggested Fix
Ignore endpoint URLs starting with https://permanently-removed.invalid/ in first place, eg. don't even store them in DB by returning false for such URLs in UserPushRepository::validateSubscriptionDetails
 
Last edited:
Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.3.8).

Change log:
Inhibit sending push notifications to permanently removed Chrome subscriptions
There may be a delay before changes are rolled out to the XenForo Community.
 
Did you delete invalid entries from the DB when you applied the patch?
The patch does not affect existing entries, it should only prevent new ones from being accepted.
 
Did you delete invalid entries from the DB when you applied the patch?
The patch does not affect existing entries, it should only prevent new ones from being accepted.

Apologies for the delay in getting back to this @Kirby

Please can you explain how to delete invalid entries from the DB

Thanks
 
There are many tools that can apply patches in unified diff format (that's basically the standard).

Ask your favourite search engine or AI assistant how to do that.

Or as the patch is really simple you can even open the diff in your favourite editor and apply the change manually.
 
Last edited:
There are many tools that can apply patches in unified diff format (that's basically the standard).

Ask your favourite search engine or AI assistant how to do that.

Or as the patch is really simple you can even open the diff in your favourite editor and apply the change manually.
I seem to have failed at both of those :(
 
Back
Top Bottom