[XB] Amazon/eBay Parser 2.1.4

[Alvin63]

I think it’s Amazon redirecting by IP maybe, if the same item is in stock on both .com and .co.uk. I’m getting the same thing if I click on our US affiliate links - it takes me to .co.uk. But if someone from the US clicks on them it takes them to .com. It’s annoying though.

 

[BarisY]

I'm getting the following warning from the Amazon Parser add-on when an RSS feed is rendered:

Error:
Undefined array key "host"

#0 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(183): XF::handlePhpError(2, '[E_WARNING] Und...', '/www/wwwroot/te...', 183)
#1 src/addons/Snog/Amazon/XF/BbCode/Renderer/Html.php(35): Snog\Amazon\XF\BbCode\Renderer\Html->addAffiliateToHref('
    

    <div class...', Array, NULL)
#2 src/addons/SV/ReportImprovements/XF/BbCode/Renderer/Html.php(19): Snog\Amazon\XF\BbCode\Renderer\Html->renderTagUrl(Array, Array, Array, Array)
#3 src/XF/BbCode/Renderer/Html.php(357): SV\ReportImprovements\XF\BbCode\Renderer\Html->renderTagUrl(Array, Array, Array, Array, Object(SV\ReportImprovements\XF\BbCode\Renderer\Html))
#4 src/addons/s9e/MediaSites/XF/BbCode/Renderer/Html.php(17): XF\BbCode\Renderer\Html->renderTag(Array, Array)
#5 src/XF/BbCode/Traverser.php(63): s9e\MediaSites\XF\BbCode\Renderer\Html->renderTag(Array, Array)
#6 src/XF/BbCode/Traverser.php(39): XF\BbCode\Traverser->renderSubTree(Array, Array)
#7 src/XF/BbCode/Traverser.php(22): XF\BbCode\Traverser->renderAst(Array, Object(SV\SignupAbuseBlocking\XF\BbCode\RuleSet), Array)
#8 src/XF/Pub/View/FeedHelper.php(135): XF\BbCode\Traverser->render('Philips'in 5000...', Object(XF\BbCode\Parser), Object(SV\SignupAbuseBlocking\XF\BbCode\RuleSet), Array)
#9 src/XF/Pub/View/Forum/Rss.php(72): XF\Pub\View\FeedHelper::setupEntryForThread(Object(Laminas\Feed\Writer\Entry), Object(SV\SearchImprovements\XF\Entity\ThreadCollab))
#10 src/XF/Pub/View/Forum/Rss.php(31): XF\Pub\View\Forum\Rss->createEntry(Object(Laminas\Feed\Writer\Feed), Object(SV\SearchImprovements\XF\Entity\ThreadCollab), 'last_post_date')
#11 src/addons/DigitalPoint/Analytics/XF/Pub/View/Forum/Rss.php(28): XF\Pub\View\Forum\Rss->renderRss()
#12 src/XF/Mvc/Renderer/AbstractRenderer.php(92): DigitalPoint\Analytics\XF\Pub\View\Forum\Rss->renderRss()
#13 src/XF/Mvc/Renderer/Xml.php(72): XF\Mvc\Renderer\AbstractRenderer->renderViewObject('XF:Forum\\Rss', '', Array)
#14 src/XF/Mvc/Dispatcher.php(473): XF\Mvc\Renderer\Xml->renderView('XF:Forum\\Rss', '', Array)
#15 src/XF/Mvc/Dispatcher.php(455): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#16 src/XF/Mvc/Dispatcher.php(414): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Rss), Object(XF\Mvc\Reply\View))
#17 src/XF/Mvc/Dispatcher.php(66): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'rss')
#18 src/XF/App.php(2830): XF\Mvc\Dispatcher->run()
#19 src/XF.php(850): XF\App->run()
#20 index.php(23): XF::runApp('XF\\Pub\\App')
#21 {main}

array(4) {
  ["url"] => string(56) "/sosyal/bolum/elektrikli-kucuk-ev-aletleri.259/index.rss"
  ["referrer"] => bool(false)
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

It points to the addAffiliateToHref() method, specifically this check:
if ($options->snog_amazonexpandshort && in_array($hrefArray['host'], ['a.co', 'amzn.to', 'amzn.eu']))

Just before that, $hrefArray is populated using:
$hrefArray = parse_url($urlstructure[0]);
It looks like some URLs passed through the RSS renderer can result in parse_url() returning an array without a host key, which then triggers the warning. Would it make sense to check that host exists before accessing $hrefArray['host']? The issue occurred while rendering a forum RSS feed.