Unknown criteria is silently treated as non-matching

Kirby

Well-known member
Affected version
2.2.10
Steps to reproduce
  1. Install XenForo Media Gallery
  2. Create a usergroup promotion to promote users ta a new usergroup with criteria
    • Has posted at least 10 messages
    • Has added at least 2 media items
  3. Deactivate XenForo Media Gallery
  4. Use the system with a promoted user
  5. Manually run cron job User group promotions
  6. Check usergroups of the user used in step 4)
  7. Activate XenForo Media Gallery
  8. Use the system with a promoted user
  9. Manually run cron job User group promotions
  10. Check usergroups of the user used in step 4)
  11. Deactivate XenForo Media Gallery
  12. Edit the promotion created in step 2) and save it without making any changes
  13. Use the system with a promoted user
  14. Manually run cron job User group promotions
  15. Check usergroups of the user used in step 4)
Expected Result
The usergroups of the promoted user are the same in steps 6) and 15)

Actual Result
The user is no longer promoted in step 6) but is promoted in step 15)

Suggested Fix
This behaviour, while technically correct, is not intuitive and does lead to confusion (as to why "Promotions do not work").
An error should be logged if an unknown criteria is detected.
 
Top