Fixed Unattended Upgrade can leave site offline

[Slavik]

Affected version

2.0

In some situations, where the upgrade may be left to one side, on a large upgrade for example, after the master data is rebuilt the user is prompted for the statistics submission.

If not quick enough this can actually cause it to timeout, and leave the site offline even though the upgrade was successful.

All upgrade steps run up to version 2.2.3 Patch 1.

Importing... Master data (Phrases)
Importing... Master data (Phrases: 27.2%)
Importing... Master data (Phrases: 48.4%)
Importing... Master data (Templates)
Importing... Master data (Templates: 15.0%)
Importing... Master data (Templates: 33.8%)
Importing... Master data (Templates: 54.5%)
Importing... Master data (Templates: 75.4%)
Rebuilding... Style properties

Upgrade completed successfully.

Note: outdated templates have been detected. This is normal after upgrading. This can be resolved by visiting the outdated templates section of the control panel. Incorporating template changes is important to ensure new features work properly and bug fixes take effect.


We are making some changes to the anonymous statistics that we collect.
* We would like to collect information about which official XenForo add-ons you have enabled.
* We would also like to collect information about the total number of third-party add-ons you have enabled.
Send anonymous usage statistics (PHP, MySQL, XF usage)? (y/n) y

In Statement.php line 35:

[E_WARNING] Error while sending STMT_PREPARE packet. PID=8481

While you can add the --skip-statistics option, even if not specified, the site should be bought back online after the master data rebuild rather than leave the upgrade message until someone returns.

 

[XF Bug Bot]

Thank you for reporting this issue, it has now been resolved. We are aiming to include any changes that have been made in a future XF release (2.2.5).

Change log:

Ensure that all pending rebuilds are triggered before asking about statistic collection when upgrading via the CLI.

There may be a delay before changes are rolled out to the XenForo Community.