Fixed Tons of errors on backend in Payment Provider log after upgrading to 2.3.5

[Jeremy P]

Closing this out then, I've updated the file in my previous message with what should be the final version in 2.3.7.

 

[FTL]

@Jeremy P Can you give us an idea when 2.3.7 will be out?

 

[Jeremy P]

Not really. We’re juggling a lot right now but it’s in the mix so not forever away.

 

[Lee]

@Static-Xbox

 

[Static-Xbox]

@Jeremy P -- Question, will this fix work on 2.2 installations?

 

[Jeremy P]

We’ve switched the implementation in 2.3 so I imagine not, but I haven't tried to be sure.

 

[Static-Xbox]

I didn't think it would, but figured I'd ask. We're slowly upgrading, but still on 2.2 for now and having issues since the basil API, not realizing it broke everything. Whoops. Motivation to upgrade a bit faster, I suppose!

 

[JamesBrown]

Attaching a hotfix in case anyone else is running into this. It may still log errors for charge.succeeded on new subscriptions, but we actually only need those for one-off payments so it should still function ok. Will try to see if we can disambiguate those somehow, but Stripe makes this painful.

Still, we absolutely cannot guarantee we will always track the latest API changes. The basil update with breaking changes was released after the most recent XF version at the time of writing. I strongly caution against ever upgrading the Stripe API without exercising due diligence. That means ensuring all connected applications (including XenForo) are compatible, making the best of the three day grace period to actually test that new and existing payments continue to function properly for all of them, and rolling back the upgrade if they do not.

@cdub The PayPal errors may be related to your IPN settings in your PayPal account. PayPal will keep sending them to XF even if XF isn't using them for payments.

When I apply that hotfix. Trying to purchase a subscription results in errors.

 

[Jeremy P]

That file should replace src/XF/Payment/Stripe.php, and not anything in src/vendor/. If you replaced src/vendor/stripe/stripe-php/Stripe.php you will need to revert it.

 

[vbresults]

Maybe a long-term solution to this issue is splitting off Stripe into its own mini-addon?

 

[Jeremy P]

I can't say we have imminent plans there right now, but yeah it did cross my mind that splitting up things which interface with external service providers could allow them to be updated independently of the core so I do think it's worth future consideration.

(I've long-wished Apple would do this with iOS Safari/WebView like Android does with their equivalents...)

 

[FTL]

@Jeremy P That would sound like a plan. This more modular approach is analogous to hardware drivers on Windows. If a bug or improvement is needed in that area, only the driver is updated, not the core Windows code. Or, if there's a new model graphics card released, again, only the graphics driver is updated. Makes sense to take this approach with external service providers as it makes code easier to maintain and quicker to update, with hopefully less bugs.

 

[JamesBrown]

That file should replace src/XF/Payment/Stripe.php, and not anything in src/vendor/. If you replaced src/vendor/stripe/stripe-php/Stripe.php you will need to revert it.

Thanks, I'd replaced the wrong stripe.php. Everything is working as it should.