The magical gc_disable()

[tyteen4a03]

https://github.com/composer/composer/commit/ac676f47f7bbc619678a29deae097b6b0710b799

Anyone want to give this a try in XenForo?

 

[Mr. Goodie2Shoes]

I did and the timing dropped about .02s

 

[tyteen4a03]

I did and the timing dropped about .02s

I don't think places outside the Deferred system would benefit much from using it, unless of course you are loading more than 100k objects per request (which means you have a bigger problem)

 

[rdn]

So to implement, I will modify or add into my custom php.ini this code

zend.enable_gc = Off

Right?

 

[Mr. Goodie2Shoes]

yes... or add this to config.php:

gc_disable();

I don't think places outside the Deferred system would benefit much from using it, unless of course you are loading more than 100k objects per request (which means you have a bigger problem)

I only tested it on normal actions... will check what happens while deferring...

 

[rdn]

or add this to config.php:

at the very bottom, will do?

 

[Mr. Goodie2Shoes]

at the very bottom, will do?

yes.

 

[tyteen4a03]

Garbage Collection has its uses so I don't recommend blindly turning it off.

 

[Xon]

Garbage Collection has its uses so I don't recommend blindly turning it off.

gc_disable only affects the garbage collector used to detect and dispose of circular references between objects.

For long lived objects which live for the entire request, it is worthless. And the current php implementation is in fact is actively harmful if you have lots of things allocated, because the threshold which triggers this GC isn't configurable or self-tuning.

 

[Mr. Goodie2Shoes]

isn't garbage collector related to global vars? I don't have that much idea about gc so I might be wrong...

 

[tyteen4a03]

gc_disable only affects the garbage collector used to detect and dispose of circular references between objects.

For long lived objects which live for the entire request, it is worthless. And the current php implementation is in fact is actively harmful if you have lots of things allocated, because the threshold which triggers this GC isn't configurable or self-tuning.

Which goes back to what I was saying: Deferred. I can see circular reference happening much more often than your typical page rendering. You shouldn't need to turn this off for normal web requests (and if you do, you probably need to review your code)