Strange extending issue...

[Liam W]

Since I tried to change to extending classes to just extending templates, and then changing it back again, the extension on XenForo_ViewPublic_Thread_View doesn't work at all - I know, because I'm outputting debug text to the screen at the beginning of the extension, and it doesn't print out.

The other 2 view classes I'm extending extend fine, it's just the thread view that doesn't.

I've no idea how to go about troubleshooting this. Any ideas?

Liam

 

[Daniel Hood]

You're going to have to post some code and your code event listeners.

 

[Liam W]

You're going to have to post some code and your code event listeners.

Well:

Event listener function:

/**
    * Listener to extend classes for drop down.
    * @param string $class
    * @param array $extend
    */
    public static function extendClass($class, array &$extend)
    {
        switch ($class)
        {
            case "XenForo_ViewPublic_Thread_Create":
            case "XenForo_ViewPublic_Thread_Reply":
            case "XenForo_ViewPublic_Thread_View":
                $extend[] = 'LiamMacros_ViewPublic_Thread_View';
                break;
        }
       
        return true;
    }

Extender:

<?php

class LiamMacros_ViewPublic_Thread_View extends XFCP_LiamMacros_ViewPublic_Thread_View
{
    public function renderHtml()
    {
        /* Get current userId */
        $userid = XenForo_Visitor::getUserId();
       
        /* @var $model LiamMacros_Model_Macros */
        $model = XenForo_Model::create('LiamMacros_Model_Macros');
       
        /* @var $usermode XenForo_Model_User */
        $usermodel = XenForo_Model::create('XenForo_Model_User');
       
        /* Get user macros */
        $usermacros = $model->getMacrosForUser($userid, true, true);
       
        /* and admin ones... */
        $adminmacros = $model->getAdminMacrosForUser($usermodel->getFullUserById($userid), true);
       
        $visitor = XenForo_Visitor::getInstance();
       
        if (is_array($usermodel->getFullUserById($userid)))
        {
            $this->_params['macros'] = $model->prepareArrayForDropDown($usermacros, $adminmacros);
           
            $this->_params['canviewmacros'] = $model->canViewMacros($visitor);
            //XenForo_CodeEvent::fire('liammacros_insert_dropdown', array(&$this->_params['macros'], &$this->_params['canviewmacros']));
        }
        parent::renderHtml();
    }
   
}

//class XFCP_LiamMacros_ViewPublic_Thread_View extends XenForo_ViewPublic_Thread_View {}

The first two classes of the extension extend fine, the final one doesn't...

 

[Liam W]

XenForo_Application::resolveDynamicClass('XenForo_ViewPublic_Thread_View')

Returns XenForo_ViewPublic_Thread_View...

 

[Daniel Hood]

Do you have an "event hint" set up?

 

[Liam W]

Do you have an "event hint" set up?

Nope.

 

[Daniel Hood]

Add echo 'class: ' . $class; before $extend[]

 

[Liam W]

Add echo 'class: ' . $class; before $extend[]

class: XenForo_ViewPublic_Thread_View

On a thread page...

 

[Daniel Hood]

ok erase that and add

$this->_params['test'] = true;

at the top of your renderHtml() function.

and add

{xen:helper dump, {$test}}

to your template.

 

[Liam W]

ok erase that and add

$this->_params['test'] = true;

at the top of your renderHtml() function.

and add

{xen:helper dump, {$test}}

to your template.

NULL appears on the page.

 

[Daniel Hood]

Ok, odd..
Try adding

echo 'test';

to the top of that function instead.
Do you have any other add ons installed that effect that template/renderer?

 

[Liam W]

Ok, odd..
Try adding

echo 'test';

to the top of that function instead.
Do you have any other add ons installed that effect that template/renderer?

SNAP!

After disabling my hide user signatures addon it all worked

Looks like I forgot to call the parent in that addon.... (whoops!)

Thanks

 

[Daniel Hood]

lol. Glad I could help.

On a side note, may I ask why you have

if (is_array($usermodel->getFullUserById($userid)))

I feel like you're adding an extra query when you don't need to.

 

[Liam W]

lol. Glad I could help.

On a side note, may I ask why you have

if (is_array($usermodel->getFullUserById($userid)))

I feel like you're adding an extra query when you don't need to.

I think it was to check for a guest or something else, otherwise it would error out. However I could use the vistior instance I have setup instead I guess...

 

[Daniel Hood]

I think it was to check for a guest or something else, otherwise it would error out. However I could use the vistior instance I have setup instead I guess...

Just figured I'd point out that you most likely don't need that extra query. Yeah, I'd recommend using the visitor instance.