Weppa333
Well-known member
Just a comment about smileys, when used with sprite map (which is default behaviour)
The "placeholder" (clear.png) path is hardwired
BbCode/Formatter/Base.php: protected $_smilieSpriteTemplate = '<img src="styles/default/xenforo/clear.png" class="mceSmilieSprite mceSmilie%1$d" alt="%2$s" title="%3$s %2$s" />';
BbCode/Formatter/Wysiwyg.php: protected $_smilieSpriteTemplate = '<img src="styles/default/xenforo/clear.png" class="mceSmilieSprite mceSmilie%1$d" alt="%2$s" unselectable="on" unselectable="on" />';
Which means every page with a smiley on it will make a call to a path out of the @imagepath specified in templates, hence out of the CDN if you're using one, etc. Of course I know this is cached after the first request, etc.
This could be optimised (at least use the style imagepath)
The "placeholder" (clear.png) path is hardwired
BbCode/Formatter/Base.php: protected $_smilieSpriteTemplate = '<img src="styles/default/xenforo/clear.png" class="mceSmilieSprite mceSmilie%1$d" alt="%2$s" title="%3$s %2$s" />';
BbCode/Formatter/Wysiwyg.php: protected $_smilieSpriteTemplate = '<img src="styles/default/xenforo/clear.png" class="mceSmilieSprite mceSmilie%1$d" alt="%2$s" unselectable="on" unselectable="on" />';
Which means every page with a smiley on it will make a call to a path out of the @imagepath specified in templates, hence out of the CDN if you're using one, etc. Of course I know this is cached after the first request, etc.
This could be optimised (at least use the style imagepath)
Upvote
1