Fixed Server error on deleting poll

[abdfahim]

Affected version

2.0.10

Everytime I delete a poll created by another member, I get this in my server error log

ErrorException: [E_NOTICE] Trying to get property of non-object src/XF/Service/Poll/Deleter.php:32
Generated by: abdfahim Oct 30, 2018 at 1:48 PM
Stack trace
#0 src/XF/Service/Poll/Deleter.php(32): XF::handlePhpError(8, '[E_NOTICE] Tryi...', '/home/root/...', 32, Array)
#1 src/XF/ControllerPlugin/Poll.php(182): XF\Service\Poll\Deleter->delete()
#2 src/XF/Pub/Controller/Thread.php(802): XF\ControllerPlugin\Poll->actionDelete(Object(XF\Entity\Poll), Array)
#3 src/XF/Mvc/Dispatcher.php(249): XF\Pub\Controller\Thread->actionPollDelete(Object(XF\Mvc\ParameterBag))
#4 src/XF/Mvc/Dispatcher.php(88): XF\Mvc\Dispatcher->dispatchClass('XF:Thread', 'PollDelete', 'json', Object(XF\Mvc\ParameterBag), 'forums', Object(XFMG\XF\Pub\Controller\Thread), NULL)
#5 src/XF/Mvc/Dispatcher.php(41): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#6 src/XF/App.php(1931): XF\Mvc\Dispatcher->run()
#7 src/XF.php(329): XF\App->run()
#8 index.php(13): XF::runApp('XF\\Pub\\App')
#9 {main}

The polls are deleted successfully, though.

 

[XF Bug Bot]

Thank you for reporting this issue. The issue is now resolved and we are aiming to include that in a future XF release (2.0.11).

Change log:

Prevent a PHP notice when deleting a poll for a thread started by a guest

Any changes made as a result of this issue being resolved may not be rolled out here until later.