1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Lack of Interest Remove ability to edit posts when merging, fixing hard-deleting content issue

Discussion in 'Closed Suggestions' started by Mouth, May 23, 2015.

  1. Mouth

    Mouth Well-Known Member

    Xon, borbole and Liam W like this.
  2. Brogan

    Brogan XenForo Moderator Staff Member

    That would require two steps when merging posts which do require editing.

    Why not just automatically apply a post edit history to the destination post as part of the merge function?
  3. Divvens

    Divvens Well-Known Member

    If a moderator abuses their power in that manner - to do something they aren't allowed to, then they shouldn't be a moderator in the first place.

    I think editing while merging is very essential and should stay the way it is.
  4. Harpers Tate

    Harpers Tate Well-Known Member

    My choice would be to retain the edit, but to record the history.
  5. shello

    shello Member

    The current behaviour of post merging implies the deletion of one or more posts from the database; only one of the merged posts (the one selected in the "merge into post" drop down) will remain in the database after the merge is completed.
    Merging posts requires only the "Manage (move, merge, etc.) thread" general moderator permission.​

    This behaviour fails to meet two expectations of the current permission model when a user only has the "Manage (move, merge, etc.) thread" permission:
    1. The user, without the "Edit post" permission, can edit a post using the merge function.
    2. The user, without the "Hard-delete post" permission, can delete a post from the database using the merge function.
    As there is no way of "unmerging" posts this behaviour also makes it very difficult to recover from a merge by mistake, requiring either manual changes in the database and/or a partial restore of a backup, if—hopefully—there is one.

    My suggestion is to change the behaviour of the post merge action to soft-delete the original posts, copying the content into a new post with the merged text. An alternative suggestion is to keep the original post data in some form in the database (perhaps a new message state?) and provide an action to revert a merge automatically.
    A second, related, suggestion is to disallow editing when merging posts if the user doesn't have the adequate permission ("Edit post").
  6. Brogan

    Brogan XenForo Moderator Staff Member

  7. shello

    shello Member

    Well, now I feel silly. I did not notice that thread when I searched this forum earlier, and it is quite recent too.
    In a way I think my suggestion complements that one, but indeed the main issue had been reported there already.

    May I suggest a merge with the thread you pointed out, @Brogan? ;)

Share This Page