Fixed Received Reaction page (inconsistent all, and N+1 query behaviour)

[Xon]

Affected version

2.1.0

In the Received Reaction, the "all" value can be inconsistent with the totals for the reaction summary totals.

This is because $reactionFinder->total(); is run separately from getUserReactionsTabSummary, might as well run just getUserReactionsTabSummary and sum the values to get the total without the extra query to count total rows.

Additional the visibility view check is still causing content to be looked up despite the call to addContentToReactions

 

[XF Bug Bot]

Thank you for reporting this issue. It has now been resolved and we are aiming to include it in a future XF release (2.1.1).

Change log:

Fix accidental N+1 query behavior on received reactions page and ensure consistent "all" vs type-specific counts.

Any changes made as a result of this issue being resolved may not be rolled out here until later.