Fixed (Re-)Assigning a report to another user creates an empty comment

Steffen

Well-known member
Affected version
2.0.9
Assigning a report to another user creates an empty comment for this report.

Screenshot from 2018-07-30 13-27-49-fs8.webp

How to reproduce:
  1. Assign a report to user A
  2. Reassign the report to user B
Maybe XenForo could log changes to the assignee in "xf_report_comment" and display the new assignee if it changes?
 
The bug here is that we only added a state_change value if the old state differs from the new state. That means that the third comment should actually look identical to the second comment.

Like this:
1535107036222.webp

That's how it worked in XF1 too and it now works the same in XF2.

I think, longer term, it might be nice to also show who the report was assigned to. We could do that a few ways. The easiest might be to just populate the "message" field of the comment... but that's a bit yuck. We'll call this fixed for now.
 
Top Bottom