1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Problems when browsing w/o Javascript

Discussion in 'Resolved Bug Reports' started by Enigma, Jul 31, 2010.

  1. Enigma

    Enigma Well-Known Member

    I turned off Javascript for a few minutes and found these issues. Reporting as bugs, since it was mentioned that everything should work without Javascript.

    I'll just copy/paste the notes I took while browsing (sorry for the multiple bug reports in one post)

    -------------------------------------
    http://xenforo.com/community/settings/following
    The "Unfollow" buttons lead to an error message "The requested member could not be found."
    -------------------------------------
    http://xenforo.com/community/settings/contact-details
    In the "identities" section of "Contact details", the checkboxes to add identities, the + image, and the X images by each input should all be added with Javascript so that they are not there when browsing w/o Javascript.
    -------------------------------------
    http://xenforo.com/community/news-feed/
    On the "Your news feed" page, the "Hide" button leads to an error page "Security error occurred. Please press back, refresh the page, and try again"
    -------------------------------------
    http://xenforo.com/community/conversations/title.XXX/reply?m=YYY
    http://xenforo.com/community/conversations/title.XXX/insert-reply
    1. After you click Reply to a message in the conversation or you click "More Options" in the quick reply editor... The title of the conversation is smack dab next to the text "Reply to Conversation". Could use a bit of space. <- Now reported here.
    2. Clicking preview here does nothing.
    -------------------------------------
    There is no way to get to the advanced search page, since there is no popup menu when the navbar search box is focused.
    -------------------------------------
    The page nav right and left arrows (the ones that do the snazzy animation) do nothing. They should probably be added via Javascript so they do not show when Javascript is not available.
    -------------------------------------

    The following 3 items are really the same issue
    -------------------------------------
    http://xenforo.com/community/misc/quick-navigation-menu
    In the quick navigation menu, add the "Cancel" button with Javascript, so it doesn't show when not using Javascript.
    -------------------------------------
    http://xenforo.com/community/members/enigma.23/trophies
    When viewing someone's trophies, add the "Close" button with Javascript so it doesn't show in the non-JS version.
    -------------------------------------
    http://xenforo.com/community/members/enigma.23/following
    Same when viewing "Members followed by X". Add the "Close" button with Javasript.
    -------------------------------------
     
  2. Brandon_R

    Brandon_R Guest

    Ill browse without js and see if i can reproduce them.
     
  3. Enigma

    Enigma Well-Known Member

    There might be more issues as well. I just clicked around randomly for about 3 minutes.
     
  4. Erik

    Erik Well-Known Member

    Just curious, are you guys using a CSS change to 'show' items when JavaScript is enabled, or are you using JS to actually append the elements to the DOM? (I guess I could find out myself, but I'm lazy... :p)
     
  5. Enigma

    Enigma Well-Known Member

    The elements are already in the DOM, since they're available and shown with CSS mouseovers when Javascript is not available.
     
  6. Erik

    Erik Well-Known Member

    That's probably the best solution. Give everything that needs JS to make sense a class of "needsjs", then in the CSS file do this:
    Code:
    .needsjs {
         display:none;
    }
    And then in your global JavaScript file:
    Code:
    $('.needsjs').show();
     
    Enigma likes this.

Share This Page