php 8.4+ compatibility

[Xon]

Affected version

2.3

This hasn't passed yet, but the discussion doesn't look like it'll have any roadblocks.

PHP: rfc:deprecate-implicitly-nullable-types

wiki.php.net

This will break things function definitions like:

function foo(User $user = null)

Thankfully the fix isn't too bad, but will be a backwards compatibility breaking change so hopefully this can get into 2.3

I've been trying to craft a regex to find these (function.*\([^\?\)]*\s*[\w]+\s*\$[\w]+\s*=\s*null\s*\) is the closest I've got), but it is somewhat false positive and error prone

 

[Kirby]

I've ran php-cs-fixer against XenForo 2.2.15, this should have catched all places that need fixing.

 

[Xon]

PHP: rfc:deprecate-implicitly-nullable-types

wiki.php.net

The RFC has passed, and will impact php 8.4.

 

[Xon]

This doesn't look to be addressed in XF2.3B1

 

[Xon]

Online PHP editor | output for 5vo1U

Run your php code online; get statistics, vld output and compare output from all versions.

3v4l.org

This doesn't error:

class a {function c(int $a = null) {} }
class b extends a {function c(?int $a = null) {} }
class d extends b {function c(int $a = null) {} }

For add-ons developers, we can just update to add ? to the type signature even if XF hasn't and it'll work

 

[Kirby]

This doesn't look to be addressed in XF2.3B1

Yeah, even new code (like for webhooks criteria) uses implicitly nullable params

 

[Chris D]

1) it's an open bug report so clearly not been addressed yet
2) the sheer majority of the code in 2.3 was written way before 8.4 was a thing

All in good time, people.

 

[Xon]

On the upside, from that 3v4L snippet this is backwards compatibility breaking change but not a forwards compatibility breaking change like most php changes.