XF 2.3 PHP 8.4 and style import

[stromb0li]

For anyone that is running XenForo 2.3.x with PHP 8.4; can you try the import style option from Admin CP and see if it initializes the /data/styles folder?
This page -> admin.php?styles/

I see the style get created, but I don't see any of the style's assets get moved to the /data/styles folder as intended. I don't see any server errors, both within XenForo and via nginx logging on the host. I've tried ruling out permissions by chmod-ing the whole directory with full rights (777), etc.

If I take the same style and import it on my dev board running PHP 8.2, the style imports and extracts the contents to the /data/styles folder as expected.

Trying to narrow down if I have a misconfiguration somewhere or if this is a potential issue with PHP 8.4 and 2.3.6?

 

[Kirby]

Symlinks?

K

Thread 'Assets are not copied from style archive when using symlinks'

Jun 30, 2022

If the path to the temporary directory does contain a symlink somewhere, copying files from a style archive does fail due to

$stdPath = File::stripRootPathPrefix($pathname, $tempDir);

if (!$this->isWithinAssetPath($stdPath, $assetPaths))
{
    continue;
}

As $tempDir does not contain the realpath, calling stripRootPathPrefix does nothing and thus isWithinAssetPath returns false which skips the file.

Suggested Solution
Call realpath before returing the path in \XF\Util\File::getTempDir()

• Kirby
• Replies: 1
• Forum: Bug reports

 

[stromb0li]

I wouldn't have ever been able to come to the conclusion that was the root cause! Thank you!

 

[Kirby]

You can either patch \XF\Util\File::getTempDir() , add a call to realpath() in the style archive import code, patch \XF\Util\File::stripRootPathPrefix() or change tempDir path so it does not contain symlinks.

I'd probably patch getTempDir().

 

[stromb0li]

Thank you!!