[OzzModz] XFRM Last Online Sort 1.0.0 Patch Level 3

[Ozzy47]

Ozzy47 submitted a new resource:

[OzzModz] XFRM Last Online Sort - Sort resources by resource owner's last activity

Adds option to sort resource list on overview page by resource owner's last activity on forum.

View attachment 249736

Permissions (Resource permissions)
View attachment 249737

Read more about this resource...

 

[Ozzy47]

Ozzy47 updated [OzzModz] XFRM Last Online Sort with a new update entry:

[OzzModz] XFRM Last Online Sort for XenForo 2.2 Update 1.0.0 Patch Level 2

Fixed incorrect return statement (was return only 1 filter)

Read the rest of this update entry...

 

[Robert9]

Do we have also the default setting now inside the acp?

 

[Ozzy47]

I think only the bug was fixed.

 

[Robert9]

Dont no why, but the filter doesn't work for me anymore.
But the code looks correct.

 

[Ozzy47]

We’ll look into it.

 

[Robert9]

Every sort is shown in the filterbar, but i dont see last_update or last_activity if i choose them.
Checked the template (Downloads was commented, set back)

 

[Robert9]

Now i remember. The default is never shown, what makes no sense.
It should be shown like all others. If i change asc/desc of the default it is shown in the filer_bar.
But the last_activity is not there, no asc/desc.
I will try to go back to the last version, but ...

1.0 2

        $sorts = parent::getAvailableResourceSorts();

        if (\XF::visitor()->hasPermission('resource', 'pb_xfrmlos_canUse'))
        {
            $sorts['last_activity'] = 'User.last_activity';
            return $sorts;
        }

        return $sorts;

and
1.0; dont know where i have the 1.0 1

        $sorts = parent::getAvailableResourceSorts();

        return $sorts + [
            'last_activity' => 'User.last_activity',
        ];

 

[Robert9]

Hmm, have rebuild everything, now it seems to be ok.
Is this possible?

1. But there is still nothing shown in the filter_bar.
2. I muss the option to use it as default in acp.

I will look for both now.

 

[Robert9]

When i try this:

        $sorts = parent::getAvailableResourceSorts();

        if (\XF::visitor()->hasPermission('resource', 'pb_xfrmlos_canUse'))
        {
            $sorts['last_activity'] = 'User.last_activity';
        }

        $visitor = \XF::visitor();
        if ($visitor->user_id == 1)
        {
            echo "<pre>";
            print_r($sorts);
            echo "</pre>";
        }


        return $sorts;
    }

I get four(!) times this:

Array
(
    [last_update] => last_update
    [resource_date] => resource_date
    [rating_weighted] => rating_weighted
    [download_count] => download_count
    [title] => title
    [last_activity] => User.last_activity
)

Why this is called four times?
Because other classes are used four times and every time we do again our function here?



Is there any reason to have the return twice times instead one time?

        $sorts = parent::getAvailableResourceSorts();

        if (\XF::visitor()->hasPermission('resource', 'pb_xfrmlos_canUse'))
        {
            $sorts['last_activity'] = 'User.last_activity';
           // =>  return $sorts; <=
        }

        return $sorts;

 

[Robert9]

{{dump($filters.order)}} => last_activity
{{dump($sortOrders)}} => no last_activity




Without $sortOrders, we dont have the text in the filterbar.

 

[Robert9]

Found it!

xfrm_overview_macros

needs a template_mod to have:

<xf:macro name="list_filter_bar" arg-filters="!" arg-baseLinkPath="!" arg-category="{{ null }}" arg-creatorFilter="{{ null }}">
    <xf:set var="$sortOrders" value="{{ {
        'last_update': phrase('xfrm_last_update'),
        'resource_date': phrase('xfrm_submission_date'),
        'rating_weighted': phrase('rating'),
        'download_count': phrase('xfrm_downloads'),
        'title': phrase('title'),
        'last_activity': phrase('last_activity')                         
    } }}" />

  <modification type="public" template="xfrm_overview_macros" modification_key="pb_xfrmlos_overview_macros" execution_order="10" enabled="1" action="str_replace">
    <find><![CDATA['title': phrase('title')]]></find>
    <replace><![CDATA[$0,
        'last_activity': phrase('last_activity')]]></replace>
  </modification>

 

[Robert9]

Now there is still the problem with last_update DESC (not the fault of this addon)

{{dump($filters.order)}} is NULL for last_update DESC

While in xfrm/cp/overview we have

        $defaultOrder = $this->options()->xfrmListDefaultOrder ?: 'last_update';
        $defaultDir = $defaultOrder == 'title' ? 'asc' : 'desc';

        if (empty($filters['order']))
        {
            $filters['order'] = $defaultOrder;
        }
        if (empty($filters['direction']))
        {
            $filters['direction'] = $defaultDir;
        }

is checked

Array
(
    [order] => last_update
    [direction] => desc
)

there is still {{dump($filters.order)}} is NULL for last_update DESC

So it seems that we loose that on the way to the template?

 

[Robert9]

last_update ASC




last_update DESC

 

[Robert9]

But how this is possible? If $filters is empty, we fill it.

        if (empty($filters['order']))
        {
            $filters['order'] = $defaultOrder;
        }
        if (empty($filters['direction']))
        {
            $filters['direction'] = $defaultDir;
        }

        $viewParams = [
            'category' => $category,
            'prefixesGrouped' => $prefixes->groupBy('prefix_group_id'),
            'filters' => $filters,
            'creatorFilter' => $creatorFilter,
            'showTypeFilters' => $showTypeFilters
        ];
        return $this->view('XFRM:Filters', 'xfrm_filters', $viewParams);

 

[Robert9]

The problem must be in

xfrm/cp/overview
public function getResourceFilterInput()

at the end $filters is empty, when last_update, desc
and not empty for last_update, asc and all others

Ok, found it:

            //if ($input['order'] != $defaultOrder || $input['direction'] != $defaultDir)
            if (1==1)
            {
                $filters['order'] = $input['order'];
                $filters['direction'] = $input['direction'];
            }

When filters == default and dir = default, we dont give filters back.
But why XF should do this? We we give infos about every filter, but not about the default one?
Makes no sense to me.

 

[Ozzy47]

Ozzy47 updated [OzzModz] XFRM Last Online Sort with a new update entry:

[OzzModz] XFRM Last Online Sort for XenForo 2.2 Update 1.0.0 Patch Level 3

Added missing template modification for filter bar

Read the rest of this update entry...

 

[Robert9]

I tried to add the "last online" as default in acp, but i failed to solve it.

 

[ChrisTERiS]

Maybe a similar mod (but for admin area) where the admin can set the display order of the resources?