A few quirks with how the method is done to add info to existing threads...
TV Starter 2.1.16
- Enable the option
Force comments to second post
- Enable the option
Enable manual updates
and give your usergroup permissions to Can add missing TV information
Scenario #1
- Create a new normal XF thread with an image attachment
- Insert the attachment as 'full' in the post
- Save the thread
- Edit the thread
- Use 'Add TV show info' to update the thread
Result = The thread is updated so the first post is the TV show info and a new second post was created with a copy of the contents that was originally in the first post. But.... the attachments are still associated with the first post instead of the new post that was created on the fly so the attachment does not show, instead you just get the 'View attachment...' link.
Scenario #2
- Create a new normal XF thread with an attachment
- Do not insert the attachment, just leave it as an attachment thumbnail
- Save the thread
- Edit the thread
- Use 'Add TV show info' to update the thread
Result = The thread is updated but nothing can be done with the attachment other than clicking the thumbnail to view it. If the thread is edited then the TMDB field options are shown with no thumbnails listed. Because of that the thumbnail can't be inserted into any of the fields like the description but it also means that it can't even be deleted from the post. I may be missing an alternative but at the moment the only way I can see of getting back to the attachment is to temporarily disable the add-on and then edit the post.
Scenario #3
Besides attachments stuff like reactions are also affected. With the current method of adding the info' to the thread any post reactions that were given to the first post stays with the modified first post instead of being moved over to the newly created post that contains the content that was originally in the first post.
Thoughts....
The current method adds the TMDB info by creating a new post with the content copied from the existing first post and then the existing first post is updated for the TMDB info.
Wouldn't it be easier to just create the new post with the TMDB info with the existing first posts meta (user, date, etc.) and then update the thread to have the new post be the
first_post_id
?
Otherwise either the Force comments to second post
option should be ignored when updating existing threads or new code is needed to update the attachments to be associated to the new post (it needs to be rendered also) along with the reactions and anything else that might be associated to the existing first post.