[OzzModz] Approval Queue Improvements

[OzzModz] Approval Queue Improvements [Paid] 2.1.3

No permission to buy ($10.00)
Overview Updates (10) Reviews (2) History Discussion
This resource has been removed and is no longer available. The following reason was provided:
This resource has been deleted by XenForo Ltd. in line with our resource housekeeping criteria.
Click to expand...
 
Very cool! The new addition is great.

I would suggest following XF language, they do not use hard delete.

When a user does not have hard hard delete permission, they see:

Delete

When they do have hard delete permission they see:

Remove from public view
and
Permanently delete

I would suggest those two for those with hard delete permissions and just Delete when they don't, like for a post. :)

But very cool, thanks!
 
Last edited:
I just tried the hard delete a new thread (guest posts allowed with moderation) from the queue and for some reason it is acting as 'do nothing' and just seems to reload. I checked permissions as admin and 'Hard-delete any thread' and 'Hard-delete any post' is set to yes and can permanently delete manually. Any ideas what might be missing?
 
Well, since my last post i decided to give some recognition to your work, buying this add-on right now.

Thank very much Ozzy for this great add-on.

Working as expected.
 
Ozzy, just for curiosity:

- Can i disable/change the color effect on hard delete threads?

That's because i use a dark theme and the color is a little confusing for me.

My procedure, since i deal with more than 5k threads/day, is to mark everything as hard delete and approve only what i need.

Just see the picture for example:

1637062576012.png
 
Hi!

I can`t buy the addon:
Oops! We ran into some problems.
The XenForo license associated with the provided license token is associated with an existing user on this site. Please contact the site administrator if you believe this is an error.
Click to expand...
 
Hi! :)

Conflict with Report Improvements by Xon 2.12.1 https://xenforo.com/community/resources/report-improvements-by-xon.6905/

URL: ./forum/approval-queue/

Bug: 2022-06-29_17-36-17.webp

HTML: 
     ErrorException: Template error: [E_USER_WARNING] Accessed unknown getter 'phrase_id' on XF:ApprovalQueue[thread, 254783] src/XF/Mvc/Entity/Entity.php:202

HTML: 
#0 [internal function]: XF\Template\Templater->handleTemplateError(512, '[E_USER_WARNING...', '/home/xenforo/h...', 202, Array)
#1 src/XF/Mvc/Entity/Entity.php(202): trigger_error('Accessed unknow...', 512)
#2 src/XF/Mvc/Entity/Entity.php(118): XF\Mvc\Entity\Entity->get('phrase_id')
#3 internal_data/code_cache/templates/l2/s2/public/approval_queue.php(191): XF\Mvc\Entity\Entity->offsetGet('phrase_id')
#4 src/XF/Template/Templater.php(1651): XF\Template\Templater->{closure}(Object(MMO\VerifiedBadge\XF\Template\Templater), Array, NULL)
#5 src/XF/Template/Template.php(24): XF\Template\Templater->renderTemplate('approval_queue', Array)
#6 src/XF/Mvc/Renderer/Html.php(50): XF\Template\Template->render()
#7 src/XF/Mvc/Dispatcher.php(460): XF\Mvc\Renderer\Html->renderView('XF:ApprovalQueu...', 'public:approval...', Array)
#8 src/XF/Mvc/Dispatcher.php(442): XF\Mvc\Dispatcher->renderView(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#9 src/XF/Mvc/Dispatcher.php(402): XF\Mvc\Dispatcher->renderReply(Object(XF\Mvc\Renderer\Html), Object(XF\Mvc\Reply\View))
#10 src/XF/Mvc/Dispatcher.php(60): XF\Mvc\Dispatcher->render(Object(XF\Mvc\Reply\View), 'html')
#11 src/XF/App.php(2352): XF\Mvc\Dispatcher->run()
#12 src/XF.php(524): XF\App->run()
#13 index.php(20): XF::runApp('XF\\Pub\\App')
#14 {main}

HTML: 
array(4) {
  ["url"] => string(30) "/forum/approval-queue/?saved=1"
  ["referrer"] => string(54) "./forum/conversations/2091126/page-4"
  ["_GET"] => array(1) {
    ["saved"] => string(1) "1"
  }
  ["_POST"] => array(0) {
  }
}
 
Hi @Ozzy47
Add-on have a bug https://xenforo.com/community/threads/ozzmodz-approval-queue-improvements-paid.186470/post-1581251
For what add-on have a
HTML: 
    <replace><![CDATA[<xf:if is="$hasMore">
    <div class="block js-approvalQueueMore">
        <div class="block-row">
            <div class="block-row-middle u-alignCenter">
                <xf:button href="{{ link('approval-queue', null, $filters + {'lastItemId': $lastItemId}) }}"
                           data-xf-click="inserter"
                           data-append=".js-approvalQueueTarget"
                           data-replace=".js-approvalQueueMore"
                           data-scroll-target="#approvalQueue-{$last.phrase_id}">
                    {{ phrase('more') }}
                </xf:button>
            </div>
        </div>
    </div>
</xf:if>
$0]]></replace>
?
Why this code?
HTML: 
{$last.phrase_id}

Do you speak russian?
В этом плагине, в данной модификации идёт обращение к пременной {$last} по геттеру phrase_id (т.е. формально phrase_id - это метод объекта $last). Но при этом объект $last в контроллере не определяется. При парсинге шаблона xenforo проверяет наличие объекта и если его нет - игнорирует, т. е. не выводит сообщения об ошибке. Ну нет объекта - и ладно. НО! Контроллер второго плагина (Xon Report Improvements) содержит строку 'last' => $unapprovedItemsSliced->last()
Здесь как раз определяется объект $last, но совсем не тот, что предполагает модификация шаблона. Ксенфоро при парсинге шаблона проверяет существование объекта $last - он есть, затем пытается обратиться к геттеру phrase_id - и получает ошибку.
Т.е. ошибка изначально в плагине [OzzModz] Approval Queue Improvements, но она маскировалась, пока на том же форуме не оказался второй плагин - Xon Report Improvements
 
You must log in or register to reply here.

Similar threads

Ozzy47
[OzzModz] Approval Queue Destination
Replies
5
Views
589
e-Dewan
e-Dewan
Semper Fidelis
Add-on Approval Queue Improvements
Replies
3
Views
1K
MrPink
M
Back
Top Bottom